drivers: mdio_nxp_enet: Fix busy wait #75625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the busy wait in the MDIO driver that was causing timing problems in systems with real time requirements performing tasks more frequently than about a millisecond. Restructure the code to be less redundant and change the busy wait kconfig to microseconds instead of millliseconds. Also actually signal to the mdio driver that it can use the interrupt instead of busy waiting, this seems to have been forgotten. Signed-off-by: Declan Snyder <[email protected]>
decsny
added
bug
zephyrbot
requested review from
danieldegrasse,
dbaluta,
dleach02,
lmajewski,
manuargue,
mmahadevan108 and
pdgendt
|
I will update the release notes and migration guide about the bug fix and kconfig change in #75001 |
pdgendt
approved these changes
Jul 9, 2024
dleach02
approved these changes
Jul 9, 2024
bperseghetti
approved these changes
Jul 10, 2024
lmajewski
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the busy wait in the MDIO driver that was causing timing problems in systems with real time requirements performing tasks more frequently than about a millisecond.
Restructure the code to be less redundant and change the busy wait kconfig to microseconds instead of millliseconds. Also actually signal to the mdio driver that it can use the interrupt instead of busy waiting, this seems to have been forgotten.
Fixes #75624