logging: Fixes in dependencies around dictionary frontend #75507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log frontend supports runtime filtering so it should be allowed to enable it even when only frontend is used with no backends. Signed-off-by: Krzysztof Chruściński <[email protected]>
Logging string stripping depends on LOG_DICTIONARY_SUPPORT being enabled and it was not set in UART dictionary frontend. Signed-off-by: Krzysztof Chruściński <[email protected]>
pdgendt
previously approved these changes
Jul 5, 2024
When userspace is used and frontend was used for logging then runtime filtering was failing because in user context filtering data was accessed and filtering data is in the kernel space. Fixing that and adding runtime filtering to the pre frontend function which is already executed in the kernel space and filter data can be accessed. Signed-off-by: Krzysztof Chruściński <[email protected]>
When NO_BACKENDS was not defined then log backends were initialized (even though not used). During the initialization filters for that backends were configured and because of that messages were not filtered out as expected. Signed-off-by: Krzysztof Chruściński <[email protected]>
dcpleung
approved these changes
Jul 8, 2024
nashif
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#67107 added support for runtime filtering in frontends but guard for that was not removed from
LOG_RUNTIME_FILTERING.UART dictionary frontend was not selecting
LOG_DICTIONARY_SUPPORT(it was selectingLOG_DICTIONARY_DBinstead) and because of thatLOG_FMT_SECTION_STRIPcould not be enabled.