LE Audio: broadcast callbacks #75491
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
bap_broadcast_callbacks
branch
from
bec6658
to
1f4d967
Compare
Thalley
changed the title
Thalley
force-pushed
the
bap_broadcast_callbacks
branch
3 times, most recently
from
af68d36
to
a8a8b47
Compare
zephyrbot
added
area: Samples
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
hermabe,
jhedberg,
jori-nordic,
kartben,
kruithofa,
larsgk,
MariuszSkamra,
nashif,
niym-ot,
pin-zephyr,
sjanc and
Vudentz
|
There is dependencies in the commits, but this PR can split into multiple smaller ones if requested by reviewers |
kruithofa
previously approved these changes
Jul 9, 2024
Thalley
force-pushed
the
bap_broadcast_callbacks
branch
2 times, most recently
from
113ae8f
to
ce68cf8
Compare
kruithofa
previously approved these changes
Sep 3, 2024
Thalley
force-pushed
the
bap_broadcast_callbacks
branch
from
ce68cf8
to
5720dea
Compare
|
Rebased to solve merge conflicts |
Thalley
force-pushed
the
bap_broadcast_callbacks
branch
2 times, most recently
from
6b97df9
to
94f8aa9
Compare
Thalley
force-pushed
the
bap_broadcast_callbacks
branch
from
94f8aa9
to
02fff7e
Compare
|
Converted to draft until CI issue is fixed |
Thalley
force-pushed
the
bap_broadcast_callbacks
branch
6 times, most recently
from
21db00c
to
171c4a8
Compare
|
Confirmed to be a controller issue: This is the valgrind report on the segfault: The callstack is: |
Thalley
force-pushed
the
bap_broadcast_callbacks
branch
2 times, most recently
from
381721f
to
b14a38a
Compare
Add callbacks that is called for the entire BIG. The BIG state is from an HCI perspective a single state change that we previously only propagated as a state change for each channel. However it may be simpler for applications and higher layers to use BIG changes to trigger their behavior. Signed-off-by: Emil Gydesen <[email protected]>
These callbacks are trigger for changes that affect the entire broadcast source, such as the BIG started and terminated events. Signed-off-by: Emil Gydesen <[email protected]>
These callbacks are trigger for changes that affect the entire broadcast source, such as the BIG started and terminated events. Signed-off-by: Emil Gydesen <[email protected]>
These callbacks are trigger for changes that affect the entire broadcast sink, such as the BIG synced and terminated events. Signed-off-by: Emil Gydesen <[email protected]>
Use the broadcast source callbacks to set the semaphores rather than the stream callbacks, as the broadcast source callbacks are better for that as they are called when all streams are ready. Signed-off-by: Emil Gydesen <[email protected]>
Use the broadcast sink callbacks to set the semaphores rather than the stream callbacks, as the broadcast sink callbacks are better for that as they are called when all streams are ready. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bap_broadcast_callbacks
branch
from
b14a38a
to
f6922a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add callbacks that affect the entire broadcast groups
fixes #75252