-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: stm: nucleo_h723zg: added flash partition to work with mcuboot #75490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution.
See comment about swap slot.
Also, it might be nice to add a storage slot while you're at it.
For next time: Please don't name the branch you contribute main
. This can cause odd conflicts with zephyr CI.
/* swap slot: 128KB */ | ||
scratch_partition: partition@e0000 { | ||
label = "image-scratch"; | ||
reg = <0x000e0000 DT_SIZE_K(128)>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking:
Scratch partition is no more required as a BOOT_SWAP_USING_MOVE
option is available in MCUBoot which will be used by default if scratch partition is not present.
This has the benefit of providing more space to application and limit this sector wear out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing.
If you think that would be more useful, I can replace the scratch partition with a storage partition of the same size.
Hi @thomasbouston You don't have to open a new PR every time you want to make changes, just amend your commit & then force push on the same branch & changes will appear in the PR. |
@thomasbouston Also, I don't know why you have a merge commit in your PR, & changes should be done in the 1st commit. |
Added code partitioning for ST Nucleo H723ZG board. Defined flash partitions including "mcuboot," "image-0,", "image-1" and "storage". Signed-off-by: Thomas Bouston <[email protected]>
Hi, I have to admit I'm pretty new to using git, so thank you very much for your advice. |
Not sure what is going on, but as I said using branch name "main" can lead to strange issues. |
Closes #75425
Add a partition for flash memory as follows:
boot_partition
: 128kslot0_partition
: 384kslot1_partition
: 384kstorage_partition
: 128k