Bluetooth: GATT: factor out notify callback #75401
Merged
+24
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- De-duplicate code - Add `LOG_WRN` on unsubscribe error Fixes zephyrproject-rtos#74720 Fixes zephyrproject-rtos#74721 Signed-off-by: Jonathan Rico <[email protected]>
zephyrbot
requested review from
alwa-nordic,
hermabe,
jhedberg,
sjanc,
Thalley and
theob-pro
jhedberg
reviewed
Jul 3, 2024
Comment on lines
+3621
to
+3622
| if (params->notify(conn, params, data, length) == BT_GATT_ITER_STOP) { | ||
| err = bt_gatt_unsubscribe(conn, params); |
There was a problem hiding this comment.
Not related to this PR, but I have to say that this looks a bit awkward as an API, since it seems like it'd be trivial (and more clear & explicit) for the callback itself to do this unsubscribe() call rather than implying it through the return value.
There was a problem hiding this comment.
I agree. I spelled it out in the function name to surface that awkwardness :)
There was a problem hiding this comment.
I also agree - Maybe something we can avoid if we get a new GATT API for EATT
jhedberg
approved these changes
Jul 3, 2024
Thalley
approved these changes
Jul 3, 2024
Comment on lines
+3621
to
+3622
| if (params->notify(conn, params, data, length) == BT_GATT_ITER_STOP) { | ||
| err = bt_gatt_unsubscribe(conn, params); |
There was a problem hiding this comment.
I also agree - Maybe something we can avoid if we get a new GATT API for EATT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOG_WRNon unsubscribe errorFixes #74720
Fixes #74721