Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: release/migration-notes/3.7: add bits about PCIe, I3C, UART and Xtensa #75343

Merged
merged 5 commits into from
Jul 4, 2024

Conversation

dcpleung
Copy link
Member

@dcpleung dcpleung commented Jul 2, 2024

Adding bits to release notes and migration notes on PCIe, I3C, UART and Xtensa.

@dcpleung dcpleung marked this pull request as ready for review July 2, 2024 19:23
@zephyrbot zephyrbot added the Release Notes To be mentioned in the release notes label Jul 2, 2024
@dcpleung dcpleung added this to the v3.7.0 milestone Jul 2, 2024
nashif
nashif previously approved these changes Jul 2, 2024
@nashif nashif added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Jul 2, 2024
Copy link
Member

@aescolar aescolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dcpleung
A few minor requests

doc/releases/migration-guide-3.7.rst Show resolved Hide resolved
doc/releases/migration-guide-3.7.rst Outdated Show resolved Hide resolved
doc/releases/release-notes-3.7.rst Outdated Show resolved Hide resolved
doc/releases/release-notes-3.7.rst Outdated Show resolved Hide resolved
doc/releases/release-notes-3.7.rst Outdated Show resolved Hide resolved
doc/releases/release-notes-3.7.rst Outdated Show resolved Hide resolved
Mention the removal of two functions that have been deprecated
since v3.3.0.

Signed-off-by: Daniel Leung <[email protected]>
Mention the moving of arch_interface.h from include/zephyr/sys/
to include/zephyr/arch/.

Signed-off-by: Daniel Leung <[email protected]>

* Added kconfig :kconfig:option:`CONFIG_XTENSA_BREAK_ON_UNRECOVERABLE_EXCEPTIONS` to guard
using break instruction for unrecoverable exceptions. Enabling the break instruction via
this kconfig may result in an infintie interrupt storm which may hinder debugging efforts.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this kconfig may result in an infintie interrupt storm which may hinder debugging efforts.
this kconfig may result in an infinite interrupt storm which may hinder debugging efforts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


* Fixed an issue where passing the 7th argument via syscall was handled incorrectly.

* Fixed an issue where :c:func:`arch_user_string_nlen` accessing unmapped memory results in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, for tone consistency

Suggested change
* Fixed an issue where :c:func:`arch_user_string_nlen` accessing unmapped memory results in
* Fixed an issue where :c:func:`arch_user_string_nlen` accessing unmapped memory resulted in

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


* Added driver to support the I3C controller on NPCX.

* Improvements and bug fixes on ``i3c_mcux``, including handling the bus being busy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and elsewhere in your PR, it might be worth referencing drivers using their actual compatible and use :dtcompatible:

Suggested change
* Improvements and bug fixes on ``i3c_mcux``, including handling the bus being busy
* Improvements and bug fixes on :dtcompatible:`nxp,mcux-i3c`, including handling the bus being busy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the dtcompatibles. I want to keep the driver file names so it is easier to cross reference.

@aescolar aescolar dismissed their stale review July 3, 2024 18:28

Probably addressed (I don't want to block until I do another pass)

This adds some bits about additions and improvements on I3C.

Signed-off-by: Daniel Leung <[email protected]>
aescolar
aescolar previously approved these changes Jul 4, 2024
doc/releases/release-notes-3.7.rst Outdated Show resolved Hide resolved
@aescolar aescolar dismissed their stale review July 4, 2024 06:08

please fix that typo, for which @kartben had provided you a suggestion already

Adds some bits on Xtensa architecture.

Signed-off-by: Daniel Leung <[email protected]>
This adds some bits about serial drivers.

Signed-off-by: Daniel Leung <[email protected]>
@aescolar aescolar merged commit b118da6 into zephyrproject-rtos:main Jul 4, 2024
16 checks passed
@dcpleung dcpleung deleted the doc/release_37 branch July 8, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes To be mentioned in the release notes Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants