wifi: Add full AP mode support (using hostapd) #75224

nxf58150 · 2024-07-01T05:44:46Z

Added support of setting up AP with hostapd.
Once flag CONFIG_WIFI_NM_HOSTAPD_AP is enabled, softAP related commands in l2 wifi_shell.c will be handled by hostapd.
Increase max value of CONFIG_WIFI_SHELL_MAX_AP_STA from 5 to 8. The softAP of NXP wifi chip can support up to 8 stations.

github-actions · 2024-07-01T05:45:25Z

Hello @nxf58150, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

jukkar · 2024-07-02T09:39:57Z

modules/hostap/src/supp_events.c

+	struct hostapd_iface *iface = ctx;
+	char *ifname = iface->bss[0]->conf->iface;


Could we call this something else than iface, it gets easily mixed up with zephyr network interface variable which is also called iface all over the place in zephyr.

How about use name "ap_ctx" instead of "iface" here?

Renamed to ap_ctx here.

jukkar · 2024-07-02T10:08:15Z

modules/hostap/src/supp_main.c

+	bss->nas_identifier      = os_strdup("ap.example.com");
+	bss->eap_sim_db          = os_strdup("unix:/tmp/hlr_auc_gw.sock");
+	os_memcpy(conf->country, "US ", 3);


The domain socket is something that is not needed in zephyr.
Also the hardcoded values look wrong.

Removed line 845.

jukkar · 2024-07-02T10:10:11Z

modules/hostap/src/supp_main.c

+	iface = net_if_get_wifi_uap();
+	/* Allocate and parse configuration for full interface files */
+	dev = net_if_get_device(iface);
+	strncpy(ifname, dev->name, IFNAMSIZ);


We should not use device name as an interface name.

jukkar · 2024-07-02T10:31:47Z

Isn't this depend on zephyrproject-rtos/hostap#15, the west.yml should be updated too in that case.

krish2718

I don't see the dynamic interfaces support for HOSTAPD_AP i.e., monitoring interface state events and accordingly stop/start using the interface, is this planned?

krish2718 · 2024-07-02T13:24:03Z

modules/hostap/Kconfig

@@ -171,6 +175,9 @@ config WIFI_NM_WPA_SUPPLICANT_WPA3
 config WIFI_NM_WPA_SUPPLICANT_AP
 	bool "AP mode support"

+config WIFI_NM_HOSTAPD_AP
+	bool "AP mode hostapd support"


hostapd based full AP mode and we can fix WIFI_NM_WPA_SUPPLICANT_AP to SoftAP mode support based on WPA supplicant

krish2718 · 2024-07-02T13:24:54Z

modules/hostap/src/supp_api.c

+	if (!hostapd_cli_cmd_v("set ssid %s", params->ssid)) {
+		goto out;
+	}


you can use a macro do the NULL check + goto out, like we did for WPA supplicant.

Below format is against the requirement of coding style and caused check fail:

I will keep it like this for now. Maybe we can do code enhancement in the future.

krish2718 · 2024-07-02T13:25:33Z

modules/hostap/src/supp_api.c

+	return ret;
+}
+
+int hapd_config_network(struct hostapd_iface *iface,


IIUC, the commands itself are common b/w SoftAP and FullAP, so, may be if you write a wrapper to choose wpa_cli_cmd_v vs hostapd_cli_cmd_v, we can reuse the code?

Do you mean reuse the code of configuring network? I think the commands between softAP and fullAP are different.

Yes.

I think the commands between softAP and fullAP are different.

Ok, let me check the differences in commands then, thanks.

krish2718 · 2024-07-02T15:33:48Z

Should we also extend wifi_nm_iface_type with FAP i.e., FULL AP?

SoftAP -> WPA supplicant
FullAP -> hostapd

nxf58150 · 2024-07-03T07:35:54Z

I don't see the dynamic interfaces support for HOSTAPD_AP i.e., monitoring interface state events and accordingly stop/start using the interface, is this planned?

nxf58150 · 2024-07-03T07:47:05Z

I don't see the dynamic interfaces support for HOSTAPD_AP i.e., monitoring interface state events and accordingly stop/start using the interface, is this planned?

Currently, we are not using dynamic interface support on hostapd. We need time to do research on this. How about we keep it like this for now? Will do code enhancement in the future.

krish2718 · 2024-07-03T07:49:59Z

I don't see the dynamic interfaces support for HOSTAPD_AP i.e., monitoring interface state events and accordingly stop/start using the interface, is this planned?

Currently, we are not using dynamic interface support on hostapd. We need time to do research on this. How about we keep it like this for now? Will do code enhancement in the future.

But other drivers might still use it (Nordic driver uses it, but still not upstream). May be add a Kconfig dependency on depends on !WIFI_NM_WPA_SUPPLICANT_INF_MON?

nxf58150 · 2024-07-03T07:54:03Z

Should we also extend wifi_nm_iface_type with FAP i.e., FULL AP?

SoftAP -> WPA supplicant

FullAP -> hostapd

Setting up AP with hostapd or wpa_supplicant is transparent for user so I think extending wifi_nm_iface_type maybe not a necessary task. By checking the type, user will know the interface is AP, no matter it is SoftAP or FullAP.
If we don't extend it, will it affect setting up AP with wpa_supplicant?

krish2718 · 2024-07-03T07:56:20Z

Should we also extend wifi_nm_iface_type with FAP i.e., FULL AP?

SoftAP -> WPA supplicant

FullAP -> hostapd

Setting up AP with hostapd or wpa_supplicant is transparent for user so I think extending wifi_nm_iface_type maybe not a necessary task. By checking the type, user will know the interface is AP, no matter it is SoftAP or FullAP. If we don't extend it, will it affect setting up AP with wpa_supplicant?

Agreed, in that case let's rename SAP ->AP and hide Soft/Full.

zephyrbot · 2024-07-04T09:16:49Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
hostap	zephyrproject-rtos/hostap@`77a4cad`	zephyrproject-rtos/hostap@`7761b17` (main)	zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nxf58150 · 2024-07-04T09:17:43Z

Isn't this depend on zephyrproject-rtos/hostap#15, the west.yml should be updated too in that case.

Updated west.yml.

Added new flag CONFIG_WIFI_NM_HOSTAPD_AP for hostapd support. Once this flag is enabled, softAP will be setup by hostapd. Both wpa_supplicant and hostapd uses same task and eloop. Included necessary hostapd files when compiling wifi samples if CONFIG_WIFI_NM_HOSTAPD_AP is enabled. Added hostapd support for all softAP command of L2 wifi shell commands. Signed-off-by: Hui Bai <[email protected]>

Enable CONFIG_IEEE80211AC flag for 11AC support when setting up AP with hostapd. Signed-off-by: Hui Bai <[email protected]>

Increase max count of CONFIG_WIFI_SHELL_MAX_AP_STA from 5 to 8. The SoftAP of NXP wifi chip can support up to 8 stations. Signed-off-by: Hui Bai <[email protected]>

Link mode shows unknown when legacy (A or bg only) device connects to APUT. Set the link mode to WIFI_2 when the host freq over 4000 and set link mode to WIFI_3 when the host freq over 2000. Signed-off-by: Hui Bai <[email protected]>

Increase wifi connect input parameters max count to 13. Previous count 7 is not enough if other security type is supported. When enabling softAP, the parameter cnx_params in cmd_wifi_ap_enable() is with static key word. Then the parameter will always save configurations of last time. Remove static keyword to eliminate effects of configs from last tim and do memset before setting up softAP. Signed-off-by: Hui Bai <[email protected]>

jukkar · 2024-08-27T12:01:17Z

@nxf58150 the hostap PR is now merged, please update manifest file and re-submit this one

Update hostap repo to latest in west.yml Signed-off-by: Hui Bai <[email protected]>

nxf58150 · 2024-08-28T02:26:03Z

@nxf58150 the hostap PR is now merged, please update manifest file and re-submit this one

Updated manifest file.

github-actions · 2024-08-28T10:52:16Z

Hi @nxf58150!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

zephyrbot added area: Wi-Fi Wi-Fi area: Networking labels Jul 1, 2024

zephyrbot requested review from jukkar, krish2718 and rlubos July 1, 2024 05:45

zephyrbot assigned krish2718 and jukkar Jul 1, 2024

nxf58150 force-pushed the hostapd_support branch 4 times, most recently from 9141d95 to de7eb95 Compare July 2, 2024 01:27

jukkar reviewed Jul 2, 2024

View reviewed changes

krish2718 changed the title ~~Hostapd support~~ wifi: Add full AP mode support (using hostapd) Jul 2, 2024

krish2718 reviewed Jul 2, 2024

View reviewed changes

nxf58150 closed this Jul 3, 2024

nxf58150 reopened this Jul 3, 2024

nxf58150 force-pushed the hostapd_support branch from de7eb95 to 46b70b5 Compare July 4, 2024 09:15

zephyrbot added manifest manifest-hostap DNM This PR should not be merged (Do Not Merge) labels Jul 4, 2024

nxf58150 added 5 commits August 27, 2024 17:28

modules: hostap: Enable CONFIG_IEEE80211AC flag for hostapd support.

23c3ca7

Enable CONFIG_IEEE80211AC flag for 11AC support when setting up AP with hostapd. Signed-off-by: Hui Bai <[email protected]>

net: l2: wifi: Increase max count of connected STA

2c381f1

Increase max count of CONFIG_WIFI_SHELL_MAX_AP_STA from 5 to 8. The SoftAP of NXP wifi chip can support up to 8 stations. Signed-off-by: Hui Bai <[email protected]>

modules: hostap: Supports link mode of legacy STA.

8e14d72

Link mode shows unknown when legacy (A or bg only) device connects to APUT. Set the link mode to WIFI_2 when the host freq over 4000 and set link mode to WIFI_3 when the host freq over 2000. Signed-off-by: Hui Bai <[email protected]>

nxf58150 force-pushed the hostapd_support branch from 35c56bd to d69369e Compare August 27, 2024 09:30

manifest: Update hostap to latest

b7256b5

Update hostap repo to latest in west.yml Signed-off-by: Hui Bai <[email protected]>

nxf58150 dismissed stale reviews from krish2718, jerome-pouiller, and jukkar via b7256b5 August 28, 2024 01:35

nxf58150 force-pushed the hostapd_support branch from d69369e to b7256b5 Compare August 28, 2024 01:35

zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Aug 28, 2024

nxf58150 requested review from jukkar, krish2718 and jerome-pouiller August 28, 2024 02:25

jukkar approved these changes Aug 28, 2024

View reviewed changes

jerome-pouiller approved these changes Aug 28, 2024

View reviewed changes

krish2718 approved these changes Aug 28, 2024

View reviewed changes

nxf58150 requested review from jukkar, krish2718 and jerome-pouiller August 28, 2024 09:48

krish2718 approved these changes Aug 28, 2024

View reviewed changes

This was referenced Aug 28, 2024

manifest: update hostap module #77215

Closed

manifest: Update hostap to fix build error of FILE #77267

Closed

nashif merged commit 386263c into zephyrproject-rtos:main Aug 28, 2024
26 of 27 checks passed

nxf58150 deleted the hostapd_support branch August 29, 2024 01:48

nxf58150 restored the hostapd_support branch August 29, 2024 01:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wifi: Add full AP mode support (using hostapd) #75224

wifi: Add full AP mode support (using hostapd) #75224

nxf58150 commented Jul 1, 2024

github-actions bot commented Jul 1, 2024

jukkar Jul 2, 2024

nxf58150 Jul 3, 2024

nxf58150 Jul 4, 2024

jukkar Jul 2, 2024

nxf58150 Jul 4, 2024

jukkar Jul 2, 2024

nxf58150 Jul 4, 2024

jukkar commented Jul 2, 2024 •

edited

Loading

krish2718 left a comment

krish2718 Jul 2, 2024

nxf58150 Jul 4, 2024

krish2718 Jul 2, 2024

nxf58150 Jul 4, 2024 •

edited

Loading

krish2718 Jul 2, 2024

nxf58150 Jul 3, 2024

krish2718 Jul 3, 2024

krish2718 commented Jul 2, 2024

nxf58150 commented Jul 3, 2024

nxf58150 commented Jul 3, 2024

krish2718 commented Jul 3, 2024

nxf58150 commented Jul 3, 2024

krish2718 commented Jul 3, 2024

zephyrbot commented Jul 4, 2024 •

edited

Loading

nxf58150 commented Jul 4, 2024

jukkar commented Aug 27, 2024

nxf58150 commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

		struct hostapd_iface *iface = ctx;
		char *ifname = iface->bss[0]->conf->iface;

wifi: Add full AP mode support (using hostapd) #75224

wifi: Add full AP mode support (using hostapd) #75224

Conversation

nxf58150 commented Jul 1, 2024

github-actions bot commented Jul 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jukkar commented Jul 2, 2024 • edited Loading

krish2718 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nxf58150 Jul 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krish2718 commented Jul 2, 2024

nxf58150 commented Jul 3, 2024

nxf58150 commented Jul 3, 2024

krish2718 commented Jul 3, 2024

nxf58150 commented Jul 3, 2024

krish2718 commented Jul 3, 2024

zephyrbot commented Jul 4, 2024 • edited Loading

nxf58150 commented Jul 4, 2024

jukkar commented Aug 27, 2024

nxf58150 commented Aug 28, 2024

github-actions bot commented Aug 28, 2024

jukkar commented Jul 2, 2024 •

edited

Loading

nxf58150 Jul 4, 2024 •

edited

Loading

zephyrbot commented Jul 4, 2024 •

edited

Loading