-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LE Audio: Reach 100% documentation coverage #75219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
audio_doc_coverage
branch
7 times, most recently
from
July 3, 2024 11:12
dce004f
to
d801c6b
Compare
Thalley
changed the title
Audio doc coverage
LE Audio: Reach 100% documentation coverage
Jul 3, 2024
Thalley
force-pushed
the
audio_doc_coverage
branch
from
July 3, 2024 12:27
d801c6b
to
983052f
Compare
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
kruithofa,
larsgk,
MariuszSkamra,
niym-ot,
pin-zephyr and
sjanc
July 3, 2024 12:27
aescolar
reviewed
Jul 9, 2024
Thalley
commented
Jul 9, 2024
Comment on lines
+47
to
+48
#define BT_TBS_CALL_FLAG_SET_INCOMING(flag) (flag &= ~BT_TBS_CALL_FLAG_OUTGOING) | ||
#define BT_TBS_CALL_FLAG_SET_OUTGOING(flag) (flag |= BT_TBS_CALL_FLAG_OUTGOING) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved from the public API as they do not belong there
Thalley
force-pushed
the
audio_doc_coverage
branch
2 times, most recently
from
July 9, 2024 09:12
44d00aa
to
e4b39f6
Compare
Add missing documentation for some defintions in audio.h Makes formatting and placement of @brief consistent. Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in bap_lc3_presets.h Also added missing C++ guards, group and version. Fixes some formatting. Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in bap.h Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in cap.h Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in csip.h Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in gmap_lc3_presets.h Also added missing C++ guards, group and version. Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in gmap.h Also added missing C++ guards, group and version. Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in has.h Signed-off-by: Emil Gydesen <[email protected]>
Format documentation for some defintions in lc3.h Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in mcc.h Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in mcs.h Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in media_proxy.h Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in micp.h Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in pacs.h Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in pbp.h Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in tbs.h Moved some internal definitions to tbs_internal.h Removed invalid TBS technology BT_TBS_TECHNOLOGY_IP that doesn't exist. Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in tmap.h Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in vcp.h Signed-off-by: Emil Gydesen <[email protected]>
Add missing documentation for some defintions in vocs.h Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
audio_doc_coverage
branch
from
July 11, 2024 12:18
5cb3f7d
to
c0287bd
Compare
kruithofa
approved these changes
Jul 11, 2024
nashif
approved these changes
Jul 12, 2024
nashif
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates, fixes and reformats LE Audio documentation in the header files.
fixes #64496