Bluetooth: Mesh: Bridge Configuration Client/Server API #75175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
akredalen,
alxelax,
Andrewpini,
asbjornsabo,
HaavardRei,
hermabe,
jhedberg,
LingaoM,
omkar3141,
PavelVPV,
sjanc,
Thalley and
Vudentz
Balaklaka
force-pushed
the
develop/bridge_cfg_client
branch
from
7227e8b
to
f700e9c
Compare
omkar3141
requested changes
Jul 1, 2024
| /** Bridging Table state entry corresponding to a entry in the Bridging Table. */ | ||
| struct bridging_table_entry { | ||
| /** Allowed directions for the bridged traffic (or bridged traffic not allowed) */ | ||
| uint8_t directions; |
There was a problem hiding this comment.
Since this will be used at many places, it could be optimized for memory footprint as:
uint32_t direction:8;
uint32_t netidx1:12;
uint32_t netidx2:12;
uint16_t addr1;
uint16_t addr2;
This might also help with mapping octets in the message to this struct.
There was a problem hiding this comment.
I also added __packed to the struct.
There was a problem hiding this comment.
I don't think this is necessary.
Balaklaka
force-pushed
the
develop/bridge_cfg_client
branch
3 times, most recently
from
ca921ab
to
6298a7a
Compare
Balaklaka
changed the title
Balaklaka
force-pushed
the
develop/bridge_cfg_client
branch
2 times, most recently
from
3796732
to
898cc75
Compare
alxelax
requested changes
Jul 2, 2024
Balaklaka
force-pushed
the
develop/bridge_cfg_client
branch
2 times, most recently
from
85b4105
to
862a73c
Compare
alxelax
requested changes
Jul 3, 2024
Balaklaka
force-pushed
the
develop/bridge_cfg_client
branch
from
862a73c
to
e849e7f
Compare
Adding documentation and function calles for the API's in Bridge Configuration Client model and Bridge Configuration Server model. Signed-off-by: Ingar Kulbrandstad <[email protected]>
alxelax
previously approved these changes
Jul 3, 2024
Balaklaka
force-pushed
the
develop/bridge_cfg_client
branch
from
e849e7f
to
947e867
Compare
omkar3141
approved these changes
Jul 3, 2024
| /** Bridging Table state entry corresponding to a entry in the Bridging Table. */ | ||
| struct bridging_table_entry { | ||
| /** Allowed directions for the bridged traffic (or bridged traffic not allowed) */ | ||
| uint8_t directions; |
There was a problem hiding this comment.
I don't think this is necessary.
alxelax
approved these changes
Jul 3, 2024
carlescufi
merged commit 470c0d1
into
zephyrproject-rtos:collab-mesh-subnet
25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding documentation and function calles for the API's in Bridge Configuration Client model and Bridge Configuration Server model.