tests: kernel: timer: timer_behavior: Tweak expected std deviation #74939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre,
peter-mitsis and
TaiJuWu
golowanow
reviewed
Jun 25, 2024
|
I like the change, agree with @golowanow the calculation should be done once before the TC_PRINT and zaasert usage |
andyross
previously approved these changes
Jun 25, 2024
npitre
previously approved these changes
Jun 25, 2024
If frequency of the system clock is lower then deviation may exceed default value (10us). Instead of adjusting the default value, test is rounding up expected standard deviation to a single clock cycle. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
force-pushed
the
fix_nrf_timer_behavior
branch
from
9ac743e
to
ebc0a71
Compare
cfriedt
previously approved these changes
Jun 28, 2024
teburd
previously approved these changes
Jun 28, 2024
golowanow
reviewed
Jul 3, 2024
| @@ -283,7 +285,7 @@ static void do_test_using(void (*sample_collection_fn)(void), const char *mechan | |||
| ", \"CONFIG_SYS_CLOCK_TICKS_PER_SEC\":%d" | |||
| ", \"CONFIG_TIMER_TEST_PERIOD\":%d" | |||
| ", \"CONFIG_TIMER_TEST_SAMPLES\":%d" | |||
| ", \"CONFIG_TIMER_TEST_MAX_STDDEV\":%d" | |||
| ", \"MAX STD DEV\":%d" | |||
There was a problem hiding this comment.
same recording output change should be in pytest/test_timer.py as well
There was a problem hiding this comment.
why the record name is different now ?
|
@andyross @peter-mitsis please review |
nordic-krch
force-pushed
the
fix_nrf_timer_behavior
branch
from
ebc0a71
to
4536c4f
Compare
golowanow
reviewed
Jul 8, 2024
Like in C test. If MAX STDDEV is lower than single clock cycle then set it to a single clock cycle. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
force-pushed
the
fix_nrf_timer_behavior
branch
from
4536c4f
to
5e700e6
Compare
andyross
approved these changes
Jul 9, 2024
| @@ -37,7 +37,10 @@ def do_analysis(test, stats, stats_count, config, sys_clock_hw_cycles_per_sec): | |||
| max_bound = (test_period + period_max_drift * test_period + | |||
| expected_period_drift) / 1_000_000 | |||
|
|
|||
| cyc_us = 1000000 / sys_clock_hw_cycles_per_sec | |||
There was a problem hiding this comment.
Naming whine: many platforms have cycle rates > 1MHz, making this value a zero. Giving it a name that looks and sounds like "cycles per microsecond" is likely to end up in a divide-by-zero as the code evolves. It's used as a clamp, so e.g. "min_cyc = ...; /* Minimum possible cycles that can be measured */' might be better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If frequency of the system clock is lower then deviation may exceed default value (10us). Instead of adjusting the default value, test is rounding up expected standard deviation to a single clock cycle.
Fixes #71863.