Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: sensor: maxim: max31865: Fix fault bit clearing #74392

Merged
merged 1 commit into from
Jul 9, 2024
Merged

drivers: sensor: maxim: max31865: Fix fault bit clearing #74392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions drivers/sensor/maxim/max31865/max31865.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,15 +177,19 @@ static char *max31865_error_to_string(uint8_t fault_register)
static int max31865_fault_register(const struct device *dev)
{
uint8_t fault_register;
uint8_t saved_fault_bits;

max31865_spi_read(dev, (REG_FAULT_STATUS), &fault_register, 1);
struct max31865_data *data = dev->data;
saved_fault_bits = data->config_control_bits & FAULT_BITS_CLEAR_MASK;
/*Clear fault register */
WRITE_BIT(data->config_control_bits, 1, 1);
data->config_control_bits &= ~FAULT_BITS_CLEAR_MASK;
configure_device(dev);
LOG_ERR("Fault Register: 0x%02x, %s", fault_register,
max31865_error_to_string(fault_register));
WRITE_BIT(data->config_control_bits, 1, 0);
data->config_control_bits |= saved_fault_bits;

return 0;
}
Expand Down
3 changes: 3 additions & 0 deletions drivers/sensor/maxim/max31865/max31865.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ LOG_MODULE_REGISTER(MAX31865, CONFIG_SENSOR_LOG_LEVEL);
#define REG_FAULT_STATUS 0x07
#define WR(reg) ((reg) | 0x80)

/* Bitmask to clear fault status bits D5, D3, and D2 */
#define FAULT_BITS_CLEAR_MASK 0x2C

/**
* RTD data, RTD current, and measurement reference
* voltage. The ITS-90 standard is used; other RTDs
Expand Down
Loading