Bluetooth: Controller: Change condition in while to Boolean #73937
+25
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
carlescufi,
cvinayak,
erbr-ot,
kruithofa,
mtpr-ot,
thoh-ot and
wopu-ot
cvinayak
previously approved these changes
Jun 7, 2024
cvinayak
dismissed
their stale review
Need the commit title to be "Bluetooth: Controller: ..."
tychofrei02
force-pushed
the
misra_rule_14_4_auditable_to_main_in_subsys
branch
from
09901c3
to
a2c7b8f
Compare
tychofrei02
changed the title
tychofrei02
changed the title
cvinayak
changed the title
nashif
approved these changes
Jun 21, 2024
31 tasks
|
This may be a nitpick, but Bluetooth and Controller with |
Use `do { ... } while (false)` instead of `do { ... } while (0)`.
Signed-off-by: frei tycho <[email protected]>
tychofrei02
force-pushed
the
misra_rule_14_4_auditable_to_main_in_subsys
branch
from
a2c7b8f
to
001909d
Compare
@cvinayak I changed it to Capitals. |
kruithofa
approved these changes
Jul 15, 2024
cvinayak
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
do { ... } while (false)instead ofdo { ... } while (0).This corresponds to following coding guideline:
This PR is part of the enhancement issue #48002 which port the coding guideline fixes done by BUGSENG on the https://github.com/zephyrproject-rtos/zephyr/tree/v2.7-auditable-branch back to main
The commit in this PR is a subset of the original auditable-branch commit:
5d02614