-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stm32 xspi driver supports Memory mapped mode for XiP #73860
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI failure : west build -p auto -b nrf54h20dk/nrf54h20/cpuapp samples/drivers/spi_flash due to #73005 |
FRASTM
force-pushed
the
xip_xspi
branch
4 times, most recently
from
June 13, 2024 14:48
64f7e3d
to
34a3098
Compare
rebase on df788d0 |
zephyrbot
added
area: Flash
platform: STM32
ST Micro STM32
area: Samples
Samples
labels
Jun 13, 2024
zephyrbot
requested review from
ajarmouni-st,
de-nordic,
erwango,
gautierg-st,
GeorgeCGV,
kartben,
marwaiehm-st and
nashif
June 13, 2024 19:37
erwango
requested changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
erwango
previously approved these changes
Jun 14, 2024
Adding the support of the memoryMapped mode to the flash_stm32_xspi driver through the CONFIG_STM32_MEMMAP That will allow XiP from the external octo_flash Erase and Write operation must Abort operations. Signed-off-by: Francois Ramu <[email protected]>
Configure the external NOR flash memory to be executable. Change the board.cmake to add the external loader for flashing (version that do not mass-erase the external flash). The address of the external flash is not needed when flashing a hex file. Signed-off-by: Francois Ramu <[email protected]>
Define the configuration to run the code_relocation application on the external memory xspi flash of the stm32h573i_dk disco kit in XIP Signed-off-by: Francois Ramu <[email protected]>
Define the configuration to run the test on the external memory xspi flash of the stm32h573i_dk disco kit in MemoryMapped Mode Reading is done with memcopy and erase/write are aborting operation to send the appropriate command Signed-off-by: Francois Ramu <[email protected]>
adding the configuration to execute the samples/drivers/spi_flash/ on the stm32h573i_dk with the external NOR in MemoryMapped mode
|
erwango
approved these changes
Jun 14, 2024
gautierg-st
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the flash_stm32_qspi or flash_stm32_ospi drivers, this PR adds the Memory Mapped mode
so that code can eXecute In Place from the external NOR flash
This is validated on the stm32H5 serie and demonstrated on the stm32h573i_dk disco kit (Macronix MX25LM51245 octo-NOR ).
Running the samples/application_development/code_relocation_nocopy/ with CONFIG_STM32_MEMMAP=y
Requires #73220