scripts: west_commands:runners: nrf_common: uicr pinreset check #73813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the default behavior of target reset on the nRF52 series if the reset pin is configured as a GPIO. If CONFIG_GPIO_AS_PINRESET is not enabled, the default flashing behavior of 'west flash' would reconfigure UICR with 'pinreset-enable,' making it unclear why the RESET pin is not acting as a GPIO. This warns the user of this behavior and switches to 'softreset' instead. Signed-off-by: Helmut Lord <[email protected]>
…NRESET Adds CONFIG_GPIO_AS_PINRESET to mocked tests Signed-off-by: Helmut Lord <[email protected]>
|
My second commit addresses the failing tests by adding "CONFIG_GPIO_AS_PINRESET" to the mocked ".conf" file. I'm unfamiliar with the west command testing framework so any suggestions would be appreciated if test coverage of this behavior is required. Thanks! |
nordicjm
reviewed
Jun 7, 2024
There was a problem hiding this comment.
This is not valid, that Kconfig is deprecated, it is a dts entry now and you cannot rely upon the value of that anyway because it's a UICR part, someone can write to the UICR enabling it or a different image can set it, it doesn't have to be the currently running application. Users should set their board files up properly to select the correct type of reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default behavior of target reset on the nRF52 series if
the reset pin is configured as a GPIO.
If CONFIG_GPIO_AS_PINRESET is not enabled, the default flashing behavior
of 'west flash' would reconfigure UICR with 'pinreset-enable,' making
it unclear why the RESET pin is not acting as a GPIO. This warns the user
of this behavior and switches to 'softreset' instead.
Signed-off-by: Helmut Lord [email protected]