Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: spi: esp32: Fix clock initialization #73807

Merged
merged 2 commits into from
Jun 10, 2024
Merged

drivers: spi: esp32: Fix clock initialization #73807

merged 2 commits into from
Jun 10, 2024

Conversation

LucasTambor
Copy link
Collaborator

The clock should be initialised only once at the
drivers init function.

Check wether the subsys needs to be disabled in
peripheral initialization according to reset reason in clock control.

@LucasTambor LucasTambor mentioned this pull request Jun 5, 2024
Closed
sylvioalves
sylvioalves previously approved these changes Jun 6, 2024
View reviewed changes
marekmatej
marekmatej requested changes Jun 6, 2024
View reviewed changes
drivers/clock_control/clock_control_esp32.c Outdated Show resolved Hide resolved
drivers/clock_control/clock_control_esp32.c Outdated Show resolved Hide resolved
drivers/clock_control/clock_control_esp32.c Show resolved Hide resolved
drivers/clock_control/clock_control_esp32.c Outdated Show resolved Hide resolved
drivers/clock_control/clock_control_esp32.c Outdated Show resolved Hide resolved
drivers/clock_control/clock_control_esp32.c Outdated Show resolved Hide resolved
drivers/clock_control/clock_control_esp32.c Outdated Show resolved Hide resolved
drivers/spi/spi_esp32_spim.c Outdated Show resolved Hide resolved
marekmatej
marekmatej previously approved these changes Jun 6, 2024
View reviewed changes
@LucasTambor LucasTambor force-pushed the bugfix/spi_clk branch 3 times, most recently from 95e1a1a to de44848 Compare June 10, 2024 13:00
@LucasTambor
drivers: spi: esp32: Fix clock initialization
9b577bc 
The clock should be initialised only once at the
drivers init function.

Check wether the subsys needs to be disabled in
peripheral initialization according to reset reason
in clock control.

Signed-off-by: Lucas Tamborrino <[email protected]>
@LucasTambor
tests: spi: spi_loopback: organize esp32 based boards
00a4ebe 
Move esp32 based boards to `soc` folder to avoid repeated files.

Signed-off-by: Lucas Tamborrino <[email protected]>
@marekmatej marekmatej mentioned this pull request Jun 10, 2024
Merged
@MaureenHelm MaureenHelm merged commit f071a26 into zephyrproject-rtos:main Jun 10, 2024
24 checks passed
@sylvioalves sylvioalves mentioned this pull request Jun 17, 2024
Merged
sylvioalves added a commit to sylvioalves/zephyr that referenced this pull request Jun 17, 2024
@sylvioalves
bugfix: driver: esp32: eth_mdio: fix shared clock check
8619fe3 
Both MDIO and Ethernet drivers share the same clock subsystem.
After clock control update in zephyrproject-rtos#73807, clock_control_on()
now returns -EALREADY for already initialized clock subsystem.
As a result, ethernet driver won't initialize as needed.

Fixes zephyrproject-rtos#74440

Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves added a commit to sylvioalves/zephyr that referenced this pull request Jun 17, 2024
@sylvioalves
driver: eth_esp32: fix shared clock check
59ef9cf 
Both MDIO and Ethernet drivers share the same clock subsystem.
After clock control update in zephyrproject-rtos#73807, clock_control_on()
now returns -EALREADY for already initialized clock subsystem.
As a result, ethernet driver won't initialize as needed.

Fixes zephyrproject-rtos#74440

Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves added a commit to sylvioalves/zephyr that referenced this pull request Jun 20, 2024
@sylvioalves
driver: eth_esp32: fix shared clock check
d687e15 
Both MDIO and Ethernet drivers share the same clock subsystem.
After clock control update in zephyrproject-rtos#73807, clock_control_on()
now returns -EALREADY for already initialized clock subsystem.
As a result, ethernet driver won't initialize as needed.

Fixes zephyrproject-rtos#74440

Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves added a commit to sylvioalves/zephyr that referenced this pull request Jun 21, 2024
@sylvioalves
driver: eth_esp32: fix shared clock check
8b3cfbf 
Both MDIO and Ethernet drivers share the same clock subsystem.
After clock control update in zephyrproject-rtos#73807, clock_control_on()
now returns -EALREADY for already initialized clock subsystem.
As a result, ethernet driver won't initialize as needed.

Fixes zephyrproject-rtos#74440

Signed-off-by: Sylvio Alves <[email protected]>
nashif pushed a commit that referenced this pull request Jun 24, 2024
@sylvioalves @nashif
driver: eth_esp32: fix shared clock check
cc29fc1 
Both MDIO and Ethernet drivers share the same clock subsystem.
After clock control update in #73807, clock_control_on()
now returns -EALREADY for already initialized clock subsystem.
As a result, ethernet driver won't initialize as needed.

Fixes #74440

Signed-off-by: Sylvio Alves <[email protected]>
fogzot pushed a commit to dndg/zephyr that referenced this pull request Jul 23, 2024
@sylvioalves @fogzot
driver: eth_esp32: fix shared clock check
fcfec98 
Both MDIO and Ethernet drivers share the same clock subsystem.
After clock control update in zephyrproject-rtos#73807, clock_control_on()
now returns -EALREADY for already initialized clock subsystem.
As a result, ethernet driver won't initialize as needed.

Fixes zephyrproject-rtos#74440

Signed-off-by: Sylvio Alves <[email protected]>
Chenhongren pushed a commit to Chenhongren/zephyr that referenced this pull request Aug 26, 2024
@sylvioalves
driver: eth_esp32: fix shared clock check
f7961ce 
Both MDIO and Ethernet drivers share the same clock subsystem.
After clock control update in zephyrproject-rtos#73807, clock_control_on()
now returns -EALREADY for already initialized clock subsystem.
As a result, ethernet driver won't initialize as needed.

Fixes zephyrproject-rtos#74440

(cherry picked from commit cc29fc1)

Original-Signed-off-by: Sylvio Alves <[email protected]>
GitOrigin-RevId: cc29fc1
Change-Id: Idcf0bb8c046f308369dcac452a5b206a79dc18e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5653396
Reviewed-by: Ting Shen <[email protected]>
Tested-by: Ting Shen <[email protected]>
Tested-by: ChromeOS Prod (Robot) <[email protected]>
Commit-Queue: Ting Shen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marekmatej marekmatej marekmatej approved these changes

@sylvioalves sylvioalves sylvioalves approved these changes

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@teburd teburd Awaiting requested review from teburd

@uLipe uLipe Awaiting requested review from uLipe

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees

@sylvioalves sylvioalves

Labels
area: Clock Control area: SPI SPI bus platform: ESP32 Espressif ESP32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LucasTambor @marekmatej @sylvioalves @MaureenHelm @zephyrbot