Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mcxn236 basic environment #73772

Merged

Conversation

NeilChen93
Copy link
Collaborator

Enable mcxn236 basic environment:
Test below cases: hello_world, button, blinky, synchronization, philosophers

@zephyrbot
Copy link
Collaborator

zephyrbot commented Jun 5, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Jun 5, 2024
Copy link
Collaborator

@danieldegrasse danieldegrasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits in this PR should be ordered so that each is bisectable. This way so that when a feature is added in a commit (such as SOC or board support), it will be possible for a developer to build for that board or SOC at the point of that commit in the repo history.

I think the commits in this PR should be ordered like so (oldest commit to newest)

  • update HAL NXP manifest
  • add dts for MCXN23x
  • add SOC support for MCXN23x
  • remove fsl_power.h for MCXN236
  • add frdm_mcxn236 board
  • add i2c test support for frdm_mcxn236 board
  • add spi test support for frdm_mcxn236 board

boards/nxp/frdm_mcxn236/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/nxp/frdm_mcxn236/board.c Show resolved Hide resolved
boards/nxp/frdm_mcxn236/board.cmake Outdated Show resolved Hide resolved
boards/nxp/frdm_mcxn236/doc/index.rst Outdated Show resolved Hide resolved
boards/nxp/frdm_mcxn236/frdm_mcxn236.dts Outdated Show resolved Hide resolved
boards/nxp/frdm_mcxn236/frdm_mcxn236.dtsi Outdated Show resolved Hide resolved
boards/nxp/frdm_mcxn236/frdm_mcxn236.yaml Outdated Show resolved Hide resolved
dts/arm/nxp/nxp_mcxn23x_common.dtsi Outdated Show resolved Hide resolved
@NeilChen93 NeilChen93 force-pushed the add_mcxn236_basic_environment branch from 96ba5d1 to 5db23e4 Compare June 6, 2024 09:08
Copy link
Collaborator

@danieldegrasse danieldegrasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, PR is looking better:)- Could you rebase to fix the merge conflict and take a look at the compliance failures when you get a chance?

dts/arm/nxp/nxp_mcxn23x_common.dtsi Show resolved Hide resolved
@dleach02 dleach02 force-pushed the add_mcxn236_basic_environment branch from a853ebe to 5d724a0 Compare June 6, 2024 20:16
@NeilChen93 NeilChen93 requested a review from decsny August 7, 2024 08:24
@NeilChen93
Copy link
Collaborator Author

Hi @decsny , I update the mcx series to "mcxn" according to your comment, please help double check again, thanks a lot.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar comments now about the devicetree, is it possible to extract a lot of this into a "common" mcxn file, similar to how there is like an RT10xx.dtsi for the RT series? maybe by renaming the other one and if needed, deleting (or adding) nodes for the mcx236?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @decsny , I don't recommend doing this, because mcxn23x and mcxnx4x are not same project. We will have other mcxn projects in the future, We want some separation between the different projects just like LPC55xx series.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I am less concerned about sharing DT anyways, since some people have some vague ambition to someday auto generate SOC DT which would result in no sharing anyways

@@ -16,7 +16,9 @@
#include <zephyr/drivers/counter.h>
#include <zephyr/pm/pm.h>
#include "fsl_ostimer.h"
#ifndef CONFIG_SOC_SERIES_MCXN23X
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like it's because MCXN236 has no fsl_power.h, for some reason, I'm not sure why though

soc/nxp/mcx/mcxn/Kconfig.soc Outdated Show resolved Hide resolved
drivers/watchdog/wdt_mcux_wwdt.c Outdated Show resolved Hide resolved
@NeilChen93 NeilChen93 force-pushed the add_mcxn236_basic_environment branch 3 times, most recently from 96e7356 to 988b36e Compare August 8, 2024 06:11
decsny
decsny previously approved these changes Aug 8, 2024
hakehuang
hakehuang previously approved these changes Aug 8, 2024
west.yml Outdated
@@ -198,7 +198,7 @@ manifest:
groups:
- hal
- name: hal_nxp
revision: 150b98fb2632d2660c8eedb5f992bcc72661fdc1
revision: pull/415/head
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet. The Zephyr side PR still needs to merge. When that occurs I will update his PR (and a couple of others)

add dts for MCXN23x

Signed-off-by: Neil Chen <[email protected]>
Change mcx series to "mcxn" and add MCXN23x support

Signed-off-by: Neil Chen <[email protected]>
remove fsl_power.h in os_timer driver for MCXN236

Signed-off-by: Neil Chen <[email protected]>
Change CONFIG_SOC_SERIES_MCXNX4X name to CONFIG_SOC_SERIES_MCXNX

Signed-off-by: Neil Chen <[email protected]>
add frdm_mcxn236 board support

Signed-off-by: Neil Chen <[email protected]>
add i2c test support for frdm_mcxn236 board

Signed-off-by: Neil Chen <[email protected]>
add spi test support for frdm_mcxn236 board

Signed-off-by: Neil Chen <[email protected]>
add uart_async_api test support for frdm_mcxn236 board

Signed-off-by: Neil Chen <[email protected]>
disable sramx, support userspace example for frdm_mcxn236 board

Signed-off-by: Neil Chen <[email protected]>
disable sramx, support sample example shared_mem for frdm_mcxn236 board

Signed-off-by: Neil Chen <[email protected]>
@dleach02 dleach02 dismissed stale reviews from hakehuang and decsny via ea8bf16 August 14, 2024 15:50
@dleach02 dleach02 force-pushed the add_mcxn236_basic_environment branch from 988b36e to ea8bf16 Compare August 14, 2024 15:50
@dleach02
Copy link
Member

@NeilChen93 I've updated your PR after the sdk2.16 PR merged

@zephyrbot zephyrbot removed manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Aug 14, 2024
@fabiobaltieri fabiobaltieri merged commit f1948ec into zephyrproject-rtos:main Aug 15, 2024
26 of 29 checks passed
@danieldegrasse danieldegrasse deleted the add_mcxn236_basic_environment branch September 16, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: I2C area: Samples Samples area: SPI SPI bus area: Timer Timer area: UART Universal Asynchronous Receiver-Transmitter area: Userspace Userspace area: Watchdog Watchdog platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants