-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mcxn236 basic environment #73772
Add mcxn236 basic environment #73772
Conversation
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commits in this PR should be ordered so that each is bisectable. This way so that when a feature is added in a commit (such as SOC or board support), it will be possible for a developer to build for that board or SOC at the point of that commit in the repo history.
I think the commits in this PR should be ordered like so (oldest commit to newest)
- update HAL NXP manifest
- add dts for MCXN23x
- add SOC support for MCXN23x
- remove
fsl_power.h
for MCXN236 - add frdm_mcxn236 board
- add i2c test support for frdm_mcxn236 board
- add spi test support for frdm_mcxn236 board
96ba5d1
to
5db23e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, PR is looking better:)- Could you rebase to fix the merge conflict and take a look at the compliance failures when you get a chance?
a853ebe
to
5d724a0
Compare
Hi @decsny , I update the mcx series to "mcxn" according to your comment, please help double check again, thanks a lot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar comments now about the devicetree, is it possible to extract a lot of this into a "common" mcxn file, similar to how there is like an RT10xx.dtsi for the RT series? maybe by renaming the other one and if needed, deleting (or adding) nodes for the mcx236?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @decsny , I don't recommend doing this, because mcxn23x and mcxnx4x are not same project. We will have other mcxn projects in the future, We want some separation between the different projects just like LPC55xx series.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I am less concerned about sharing DT anyways, since some people have some vague ambition to someday auto generate SOC DT which would result in no sharing anyways
drivers/timer/mcux_os_timer.c
Outdated
@@ -16,7 +16,9 @@ | |||
#include <zephyr/drivers/counter.h> | |||
#include <zephyr/pm/pm.h> | |||
#include "fsl_ostimer.h" | |||
#ifndef CONFIG_SOC_SERIES_MCXN23X |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like it's because MCXN236 has no fsl_power.h, for some reason, I'm not sure why though
96e7356
to
988b36e
Compare
west.yml
Outdated
@@ -198,7 +198,7 @@ manifest: | |||
groups: | |||
- hal | |||
- name: hal_nxp | |||
revision: 150b98fb2632d2660c8eedb5f992bcc72661fdc1 | |||
revision: pull/415/head |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet. The Zephyr side PR still needs to merge. When that occurs I will update his PR (and a couple of others)
add dts for MCXN23x Signed-off-by: Neil Chen <[email protected]>
Change mcx series to "mcxn" and add MCXN23x support Signed-off-by: Neil Chen <[email protected]>
remove fsl_power.h in os_timer driver for MCXN236 Signed-off-by: Neil Chen <[email protected]>
Change CONFIG_SOC_SERIES_MCXNX4X name to CONFIG_SOC_SERIES_MCXNX Signed-off-by: Neil Chen <[email protected]>
add frdm_mcxn236 board support Signed-off-by: Neil Chen <[email protected]>
add i2c test support for frdm_mcxn236 board Signed-off-by: Neil Chen <[email protected]>
add spi test support for frdm_mcxn236 board Signed-off-by: Neil Chen <[email protected]>
add uart_async_api test support for frdm_mcxn236 board Signed-off-by: Neil Chen <[email protected]>
disable sramx, support userspace example for frdm_mcxn236 board Signed-off-by: Neil Chen <[email protected]>
disable sramx, support sample example shared_mem for frdm_mcxn236 board Signed-off-by: Neil Chen <[email protected]>
988b36e
to
ea8bf16
Compare
@NeilChen93 I've updated your PR after the sdk2.16 PR merged |
f1948ec
into
zephyrproject-rtos:main
Enable mcxn236 basic environment:
Test below cases: hello_world, button, blinky, synchronization, philosophers