Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #72394 and additional checks for CONFIG_FILE_SYSTEM_MAX_FILE_NAME #73596

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Fix for issue #72394 and additional checks for CONFIG_FILE_SYSTEM_MAX_FILE_NAME #73596

merged 2 commits into from
Jun 4, 2024

Conversation

de-nordic
Copy link
Collaborator

@de-nordic de-nordic commented May 31, 2024 •
edited
Loading

Two commits:

  1. Fix for MAX_FILE_NAME defaulting for LittleFS to 256, while max allowed is now 255
  2. improved checks of CONFIG_FILE_SYSTEM_MAX_FILE_NAME

Fixes #72394

@de-nordic
fs: Fix MAX_FILE_NAME setting for LittleFS
668ef10 
Fix MAX_FILE_NAME for LittleFS, which was set to 255, while currently
allowed is 255.

Fixes zephyrproject-rtos#72394

Signed-off-by: Dominik Ermel <[email protected]>
@de-nordic
fs: Improved CONFIG_FILE_SYSTEM_MAX_FILE_NAME processing
b537241 
The processing of CONFIG_FILE_SYSTEM_MAX_FILE_NAME override for
MAX_FILE_NAME has been improved to limit possibility to set it to
value that is not allowed by any of the in-tree subsystems, when
such subsystem is enabled.
When no in-tree subsystem is allowed the value is still not limited.

Signed-off-by: Dominik Ermel <[email protected]>
@de-nordic de-nordic self-assigned this May 31, 2024
@zephyrbot zephyrbot requested review from Laczen and nashif May 31, 2024 19:15
@nashif nashif requested a review from dkalowsk June 4, 2024 19:34
dkalowsk
dkalowsk approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@dkalowsk dkalowsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first commit is how we solved it internally. The second is an interesting take on how to use the file length, and should work fine.

@nashif nashif merged commit c9a2136 into zephyrproject-rtos:main Jun 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nashif nashif nashif approved these changes

@dkalowsk dkalowsk dkalowsk approved these changes

@Laczen Laczen Awaiting requested review from Laczen

Assignees

@de-nordic de-nordic

Labels
area: File System
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LittleFS max file name length is incorrect
4 participants
@de-nordic @nashif @dkalowsk @zephyrbot