-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrf54h20: add support for fast SPIM12x instances #73545
Merged
fabiobaltieri
merged 9 commits into
zephyrproject-rtos:main
from
nika-nordic:add_fast_spim_nrf54h_zephyrupstream
Jun 5, 2024
Merged
nrf54h20: add support for fast SPIM12x instances #73545
fabiobaltieri
merged 9 commits into
zephyrproject-rtos:main
from
nika-nordic:add_fast_spim_nrf54h_zephyrupstream
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory region defined in devicetree can have attributes that are not intended to be parsed by MPU library, but might be valid for other components. Signed-off-by: Nikodem Kastelik <[email protected]>
zephyrbot
requested review from
carlocaione,
galak,
ithinuel,
jaz1-nordic,
kl-cruz,
magp-nordic,
MaureenHelm,
microbuilder,
stephanosio,
tbursztyka and
teburd
May 30, 2024 21:36
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nordic
DNM
This PR should not be merged (Do Not Merge)
labels
May 30, 2024
nika-nordic
force-pushed
the
add_fast_spim_nrf54h_zephyrupstream
branch
4 times, most recently
from
June 3, 2024 17:16
17b2931
to
f744a67
Compare
anangl
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jun 5, 2024
This memory region is used for not only but also DMA transfers of the fast peripherals. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]>
anangl
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jun 5, 2024
Fast SPIM instances must not have CLOCKPIN setting applied to MOSI. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]>
anangl
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jun 5, 2024
…nc test case In test cases checking async API, use async API for both controller and peripheral devices. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]>
anangl
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jun 5, 2024
Chip Select signal must be deactivated only after transaction is finalized. In async case this means it cannot be done from `transceive` call context, as this context is left as soon as transfer is initialized. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]>
anangl
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jun 5, 2024
Updated hal_nordic revision brings update to nrfx SPIM driver, allowing external configuration of ENABLE register needed to mitigate SPI bus glitches when using CTRLSEL pins. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]>
anangl
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jun 5, 2024
SPIM12x instances can perform DMA only from memory region that is cacheable by default. SPIM12x instances pins are configured via CTRLSEL mechanism, which prevents the GPIO registers from ensuring correct bus state when peripheral does not drive the bus lines. External configuration of SPIM12x ENABLE register fixes this issue. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]>
anangl
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jun 5, 2024
… features SPI is now supported on nRF54H20 PPR CPU. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]>
anangl
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jun 5, 2024
SPIM12x have more capabilities than SPIM13x, so it should be tested separately. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]>
carlescufi
approved these changes
Jun 5, 2024
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
Memory region defined in devicetree can have attributes that are not intended to be parsed by MPU library, but might be valid for other components. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]> (cherry picked from commit b5d3b1f)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
This memory region is used for not only but also DMA transfers of the fast peripherals. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]> (cherry picked from commit f4ff637)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
Fast SPIM instances must not have CLOCKPIN setting applied to MOSI. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]> (cherry picked from commit a313fba)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
…nc test case In test cases checking async API, use async API for both controller and peripheral devices. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]> (cherry picked from commit 83acb95)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
Chip Select signal must be deactivated only after transaction is finalized. In async case this means it cannot be done from `transceive` call context, as this context is left as soon as transfer is initialized. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]> (cherry picked from commit 14ea490)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
Updated hal_nordic revision brings update to nrfx SPIM driver, allowing external configuration of ENABLE register needed to mitigate SPI bus glitches when using CTRLSEL pins. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]> (cherry picked from commit f74e796)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
SPIM12x instances can perform DMA only from memory region that is cacheable by default. SPIM12x instances pins are configured via CTRLSEL mechanism, which prevents the GPIO registers from ensuring correct bus state when peripheral does not drive the bus lines. External configuration of SPIM12x ENABLE register fixes this issue. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]> (cherry picked from commit 590a1d1)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
… features SPI is now supported on nRF54H20 PPR CPU. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]> (cherry picked from commit 0b44283)
anangl
pushed a commit
to anangl/sdk-zephyr
that referenced
this pull request
Jul 1, 2024
SPIM12x have more capabilities than SPIM13x, so it should be tested separately. Upstream PR: zephyrproject-rtos/zephyr#73545 Signed-off-by: Nikodem Kastelik <[email protected]> (cherry picked from commit 0741603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: ARM
ARM (32-bit) Architecture
area: Pinctrl
area: SPI
SPI bus
manifest
manifest-hal_nordic
platform: nRF
Nordic nRFx
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.