Change nxp,kinetis-lptmr compat string to nxp,lptmr #73280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename nxp,kinetis-lptmr compat to nxp,lptmr. Because of concerns over breaking downstream users, keep support for the old compatible temporarily and make it clear it should be changed. Signed-off-by: Declan Snyder <[email protected]>
Convert compats in tree from nxp,kinetis-lptmr to nxp,lptmr string. Signed-off-by: Declan Snyder <[email protected]>
List change to nxp,lptmr compatible in migration guide. Signed-off-by: Declan Snyder <[email protected]>
zephyrbot
added
platform: NXP
zephyrbot
requested review from
aescolar,
butok,
dbaluta,
DerekSnell,
galak,
kartben,
manuargue,
nashif,
nordic-krch and
yvanderv
decsny
removed request for
dbaluta,
kartben,
nashif,
manuargue,
yvanderv,
galak and
nordic-krch
decsny
requested review from
kartben,
nashif,
galak,
nordic-krch and
aescolar
and removed request for
aescolar and
DerekSnell
EmilioCBen
approved these changes
May 24, 2024
danieldegrasse
approved these changes
May 24, 2024
aescolar
reviewed
May 24, 2024
| @@ -112,6 +112,10 @@ Device Drivers and Devicetree | |||
| }; | |||
| }; | |||
|
|
|||
| * The :dtcompatible:`nxp,kinetis-lptmr` compatible string has been changed to | |||
| :dtcompatible:`nxp,lptmr`. The old string will be usable for a short time, but | |||
| should be replaced for it will be removed in the future. | |||
There was a problem hiding this comment.
Suggested change
| should be replaced for it will be removed in the future. | |
| should be replaced as it will be removed in the future. |
There was a problem hiding this comment.
Either works. 'For' is more formal and 'as' is more conversational.
There was a problem hiding this comment.
At least for me, when reading it, it broke the flow of the sentence and made me need to reparse it to realize it was an archaic way of writing and not just a broken sentence. I would change it for readability.
henrikbrixandersen
approved these changes
May 26, 2024
butok
approved these changes
May 27, 2024
mmahadevan108
approved these changes
May 28, 2024
dleach02
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danieldegrasse @butok @EmilioCBen to resolve discussion on #73236