Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: security: Update cryptographic documentation #73241

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

ceolin
Copy link
Member

@ceolin ceolin commented May 23, 2024

Remove TinyCrypt documentation and add PSA Crypto.

@ceolin
Copy link
Member Author

ceolin commented May 23, 2024

@valeriosetti @tomi-font FYI !

nashif
nashif previously approved these changes May 23, 2024
dleach02
dleach02 previously approved these changes May 23, 2024
doc/security/security-overview.rst Show resolved Hide resolved
doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@valeriosetti valeriosetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only this typo fix on top of @tomi-font ones

doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this PR would be a good opportunity to add relevant entries to the release notes? (and migration guide if anything is needed for end users?)

Comment on lines 31 to 33
* Algorithm Flexibility

PSA Crypto API supports a wide range of cryptographic algorithms,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider using the following construct ("definition lists") for all these types of enumerations in the file:

Suggested change
* Algorithm Flexibility
PSA Crypto API supports a wide range of cryptographic algorithms,
Algorithm Flexibility
PSA Crypto API supports a wide range of cryptographic algorithms,

This makes things much easier to read

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we have a design guideline for documentation ? If don't would be nice to have these guidelines documented to get a consistent look'n feel

doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
@ceolin ceolin dismissed stale reviews from dleach02 and nashif via a9746df May 24, 2024 21:25
@ceolin ceolin force-pushed the doc/security/crypto branch 2 times, most recently from a9746df to 50ad9c2 Compare May 24, 2024 21:28
@ceolin
Copy link
Member Author

ceolin commented May 24, 2024

@tomi-font @valeriosetti @kartben Thanks for the review. I have addressed all comments. Please take a look again

@ceolin ceolin requested review from kartben and tomi-font May 24, 2024 21:30
@ceolin
Copy link
Member Author

ceolin commented May 24, 2024

looks like this PR would be a good opportunity to add relevant entries to the release notes? (and migration guide if anything is needed for end users?)

Yep, we will need it, but we are still doing a lot of changes. Lets wait a little bit more to work on that.

This section is more high-level and it is better to have it sooner than later.

Copy link
Collaborator

@tomi-font tomi-font left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some final minor nits.

doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
doc/services/crypto/psa_crypto.rst Outdated Show resolved Hide resolved
@tomi-font
Copy link
Collaborator

looks like this PR would be a good opportunity to add relevant entries to the release notes? (and migration guide if anything is needed for end users?)

Not certain that's what you're pointing at, but for my part I've been adding entries along with the changes. Would be glad to receive your comments on them if you have any: #73267, #72565

Flavio Ceolin added 3 commits May 28, 2024 20:22
Zephyr's transition to PSA Crypto API and demoting TinyCrypt.
Lets not promote TinyCrypt in the overview.

Signed-off-by: Flavio Ceolin <[email protected]>
TinyCrypt is being removed from Zephyr in favor of PSA Crypto.

Signed-off-by: Flavio Ceolin <[email protected]>
Add PSA Crypto in the cryptographic services
section.

Signed-off-by: Flavio Ceolin <[email protected]>
@ceolin
Copy link
Member Author

ceolin commented May 28, 2024

@tomi-font thanks for reviewing it :)

@ceolin
Copy link
Member Author

ceolin commented May 30, 2024

@kartben can you take another look please ?

Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks! should there be another round of updates (or future PRs on the topic) it would be great to add a redirect (doc/_scripts/redirects.py) from the dropped tinycrypt page to somewhere else (probably services/crypto/index) so that it's not a 404 for folks browsing e.g. https://docs.zephyrproject.org/3.6.0/services/crypto/tinycrypt.html and clicking on "see the latest version ..."

@nashif nashif assigned ceolin and unassigned d3zd3z Jun 4, 2024
@nashif nashif merged commit 1a6bdb2 into zephyrproject-rtos:main Jun 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants