Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: smartbond: Move PM_DEVICE dependency to soc #72663

Conversation

kasjer
Copy link
Contributor

@kasjer kasjer commented May 13, 2024

For DA1469x if PM config is selected PM_DEVICE must also be selected for GPIO to work when device enters/exists deep sleep.

Previously GPIO and regulator drivers selected PM_DEVICE when PM was enabled.
Now it is moved to SOC instead.

PM_DEVICE selection in GPIO could result in circular dependency for mcux if MEMC_MCUX_FLEXSPI (which is already dependent on PM_DEVICE) was to be additionally dependent on GPIO.

This should fix #72556

For DA1469x if PM config is selected PM_DEVICE must also
be selected for GPIO to work when device enters/exists
deep sleep.

Previously GPIO and regulator drivers selected PM_DEVICE
when PM was enabled.
Now it is moved to SOC instead.

PM_DEVICE selection in GPIO could result in circular dependency
for mcux if MEMC_MCUX_FLEXSPI (which is already dependent on PM_DEVICE)
was to be additionally dependent on GPIO.

Signed-off-by: Jerzy Kasenberg <[email protected]>
@kasjer kasjer force-pushed the kasjer/da1469x-pm-pm_device-dependency branch from b5c68dd to 5c0880f Compare May 13, 2024 11:25
@aasinclair aasinclair added the bug The issue is a bug, or the PR is fixing a bug label May 13, 2024
@aescolar aescolar added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label May 14, 2024
@danieldegrasse danieldegrasse removed their request for review May 14, 2024 14:52
@aescolar aescolar merged commit f2e3d3f into zephyrproject-rtos:main May 14, 2024
25 checks passed
@kasjer kasjer deleted the kasjer/da1469x-pm-pm_device-dependency branch May 15, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: GPIO area: Regulators bug The issue is a bug, or the PR is fixing a bug platform: Renesas SmartBond Renesas Electronics Corporation, SmartBond Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select GPIO is broken
7 participants