Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LE Audio: Codec meta lang update #72584

Merged
merged 2 commits into from
Jun 12, 2024
Merged

LE Audio: Codec meta lang update #72584

merged 2 commits into from
Jun 12, 2024

Conversation

Thalley
Copy link
Collaborator

@Thalley Thalley commented May 10, 2024

fixes #68712

@Thalley Thalley force-pushed the codec_meta_lang_update branch 3 times, most recently from 6ee5b04 to 1627015 Compare May 10, 2024 14:50
@Thalley
Copy link
Collaborator Author

Thalley commented May 13, 2024

CI is failing because it doesn't allow for non-static const char arrays.

@Thalley Thalley marked this pull request as ready for review May 13, 2024 07:24
@aescolar
Copy link
Member

CI is failing because it doesn't allow for non-static const char arrays.

So why don't you change it to be static const? :)
https://lore.kernel.org/lkml/[email protected]/
At least I cannot see any drawback of defining it static const..

kruithofa
kruithofa previously approved these changes May 13, 2024
View reviewed changes
@Thalley
Copy link
Collaborator Author

Thalley commented May 13, 2024

CI is failing because it doesn't allow for non-static const char arrays.

So why don't you change it to be static const? :) https://lore.kernel.org/lkml/[email protected]/ At least I cannot see any drawback of defining it static const..

I can change it to static const, but that seems weird to me when stack allocated values in this case is just fine.

Someone more clever than me might know, but why is it only for strings (char arrays)?
It doesn't complain about const uint8_t myval[] = {'0'} but does for const char myval[] = {'0'}.
Why not apply the same rule for any const array or value?

@Thalley Thalley force-pushed the codec_meta_lang_update branch 2 times, most recently from bbc731c to 75b1ef6 Compare May 20, 2024 16:44
@Thalley Thalley requested a review from kruithofa May 22, 2024 11:05
@Thalley
Copy link
Collaborator Author

Thalley commented Jun 3, 2024

Rebased to solve merge conflicts

@Thalley Thalley requested a review from kruithofa June 3, 2024 07:30
kruithofa
kruithofa previously approved these changes Jun 3, 2024
View reviewed changes
larsgk
larsgk previously approved these changes Jun 3, 2024
View reviewed changes
@aescolar
Copy link
Member

aescolar commented Jun 3, 2024

@Thalley rebase needed

@Thalley Thalley dismissed stale reviews from larsgk and kruithofa via 76e3e44 June 3, 2024 13:46
@Thalley
Copy link
Collaborator Author

Thalley commented Jun 3, 2024

Rebased to solve merge conflicts

@Thalley Thalley requested review from kruithofa and larsgk June 3, 2024 13:50
kruithofa
kruithofa previously approved these changes Jun 4, 2024
View reviewed changes
aescolar
aescolar previously requested changes Jun 4, 2024
View reviewed changes
doc/releases/migration-guide-3.7.rst Show resolved Hide resolved
@aescolar aescolar dismissed their stale review June 4, 2024 08:36

Addressed

@Thalley Thalley requested a review from aescolar June 4, 2024 09:22
@hermabe hermabe removed their request for review June 4, 2024 10:14
@Thalley
Bluetooth: Audio: Rename stream_lang to lang
85b1f1e 
Remove the "stream" part of the value and functions to
better fit with the name in the assigned numbers document.

Signed-off-by: Emil Gydesen <[email protected]>
@Thalley
Bluetooth: Audio: Change lang to 3-byte value from uint32_t
04a56f0 
The 3-byte value suits the assigned number much better,
and also allows for less memory copies when getting and
setting the values.

Signed-off-by: Emil Gydesen <[email protected]>
@zephyrbot zephyrbot requested a review from niym-ot June 4, 2024 10:41
@nashif nashif merged commit be307f8 into zephyrproject-rtos:main Jun 12, 2024
24 checks passed
@Thalley Thalley deleted the codec_meta_lang_update branch June 12, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsgk larsgk larsgk approved these changes

@kruithofa kruithofa kruithofa approved these changes

@asbjornsabo asbjornsabo Awaiting requested review from asbjornsabo

@Casper-Bonde-Bose Casper-Bonde-Bose Awaiting requested review from Casper-Bonde-Bose

@fredrikdanebjer fredrikdanebjer Awaiting requested review from fredrikdanebjer

@jhedberg jhedberg Awaiting requested review from jhedberg

@kartben kartben Awaiting requested review from kartben

@MariuszSkamra MariuszSkamra Awaiting requested review from MariuszSkamra

@nashif nashif Awaiting requested review from nashif

@pin-zephyr pin-zephyr Awaiting requested review from pin-zephyr

@sjanc sjanc Awaiting requested review from sjanc

@Vudentz Vudentz Awaiting requested review from Vudentz

@aescolar aescolar Awaiting requested review from aescolar

@niym-ot niym-ot Awaiting requested review from niym-ot

Assignees

@Thalley Thalley

Labels
area: Bluetooth Audio area: Bluetooth Release Notes To be mentioned in the release notes
Projects
Bluetooth LE Audio
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LE Audio: Make stream_lang uint8_t[3] instead of uint32_t
6 participants
@Thalley @aescolar @larsgk @kruithofa @nashif @zephyrbot