-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: gpio: Add support for Apollo3 SoCs GPIO #72438
drivers: gpio: Add support for Apollo3 SoCs GPIO #72438
Conversation
cba7a79
to
de14297
Compare
hi @henrikbrixandersen @mnkp, please help to review and approve this PR, thank you! |
Hi @carlescufi , should the collaborators of Ambiq platform be requested review the affected soc/board/binding changes automatically by zephyrbot? Ambiq Platforms: |
Yes, they should. Not sure why they aren't. It's perhaps because you were not part of the GitHub team and org. I have now invited you all. |
Hi @carlescufi, I have not received the invitation yet, maybe because my github username is different from that in MAINTAINERS.yml? could you please invite this account again? I'll update MAINTAINERS.yml later. thank you! |
These need to match up first. Please submit a PR for updating |
@henrikbrixandersen created one here #72500 |
@AlessandroLuo We may need to add CONFIG_GPIO=y in board default config due to the GPIO kconfig dependency loop issue. The previous comment is dismissed as I should have found the cause of the problem. #72556 |
The board changes look good to me. |
de14297
to
cfc9a1f
Compare
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
This commit adds support for the GPIO which can be found in Apollo3 SoCs Signed-off-by: Hao Luo <[email protected]>
cfc9a1f
to
3e7e983
Compare
@henrikbrixandersen @mnkp any more comments? if not please help to approve, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Board and device tree changes look good to me. @henrikbrixandersen @mnkp We would appreciate your review on the GPIO driver changes. Thanks.
Hi @carlescufi could you please invite me again, MAINTAINERS.yml has been updated correctly. |
This commit adds support for the GPIO which
can be found in Apollo3 SoCs