net: conn_mgr: Add IPv4 and IPv6 tracking #72393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't added unit tests for the new feature, nor have I updated old unit tests. I am going to put that off until after I transition my work laptop to linux, since it will be much easier to do local testing in that environment |
glarsennordic
force-pushed
the
zcmv46
branch
2 times, most recently
from
45c0833
to
fa2e3b9
Compare
|
@simensrostad I cannot add you as reviewer, but please feel free to review |
simensrostad
approved these changes
May 23, 2024
rlubos
reviewed
May 28, 2024
glarsennordic
force-pushed
the
zcmv46
branch
2 times, most recently
from
c43535e
to
efbc21f
Compare
rlubos
previously approved these changes
Jun 6, 2024
jukkar
reviewed
Jun 6, 2024
jukkar
reviewed
Jun 6, 2024
glarsennordic
force-pushed
the
zcmv46
branch
2 times, most recently
from
ae44b2e
to
13957b9
Compare
jukkar
previously approved these changes
Jun 7, 2024
rlubos
previously approved these changes
Jun 7, 2024
kartben
requested changes
Jun 7, 2024
Comment on lines
+80
to
+83
| - :c:macro:`NET_EVENT_L4_IPV4_CONNECTED` | ||
| - :c:macro:`NET_EVENT_L4_IPV4_DISCONNECTED` | ||
| - :c:macro:`NET_EVENT_L4_IPV6_CONNECTED` | ||
| - :c:macro:`NET_EVENT_L4_IPV6_DISCONNECTED` |
There was a problem hiding this comment.
Suggested change
| - :c:macro:`NET_EVENT_L4_IPV4_CONNECTED` | |
| - :c:macro:`NET_EVENT_L4_IPV4_DISCONNECTED` | |
| - :c:macro:`NET_EVENT_L4_IPV6_CONNECTED` | |
| - :c:macro:`NET_EVENT_L4_IPV6_DISCONNECTED` | |
| - :c:enumerator:`NET_EVENT_L4_IPV4_CONNECTED` | |
| - :c:enumerator:`NET_EVENT_L4_IPV4_DISCONNECTED` | |
| - :c:enumerator:`NET_EVENT_L4_IPV6_CONNECTED` | |
| - :c:enumerator:`NET_EVENT_L4_IPV6_DISCONNECTED` |
There was a problem hiding this comment.
Are you certain these should be changed to :c:enumerator:? They are defined as macros whose values derive from the actual enumerator values
There was a problem hiding this comment.
Of course! Read too fast and missed the difference between the "CMD" enumerators ans the macros
kartben
requested changes
Jun 7, 2024
Instead of incrementing and decrementing global counter, just recompute the ready-count from scratch every time conn_mgr_mon_handle_update is called. This will simplify the introduction of additional ready count types. This should have no externally observable impact on the behavior of conn_mgr. Signed-off-by: Georges Oates_Larsen <[email protected]>
Don't track up/down blame separately. Instead, track a single last-blame iface. Don't track blame iface inside set_ready. Instead, track directly inside handle_update. These two changes will simplify the addition of blame for IPv4- and IPv6-specific events. Signed-off-by: Georges Oates_Larsen <[email protected]>
conn_mgr now fires: - NET_EVENT_L4_IPV4_CONNECTED - NET_EVENT_L4_IPV4_DISCONNECTED - NET_EVENT_L4_IPV6_CONNECTED - NET_EVENT_L4_IPV6_DISCONNECTED These events track whether there are any ready ifaces offering specifically IPv4 or specifically IPv6 connectivity. Signed-off-by: Georges Oates_Larsen <[email protected]>
Modify the test cycle routines to verify recently added IPv4- and IPv6-specific events. Signed-off-by: Georges Oates_Larsen <[email protected]>
Add descriptions for recently introduced IPv4 and IPv6 connectivity events to the net event monitor. Signed-off-by: Georges Oates_Larsen <[email protected]>
jukkar
approved these changes
Jun 7, 2024
rlubos
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.