Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtensa: add sample_controller32 SoC and qemu_xtensa/sample_controller32/mpu board #71893

Merged

Conversation

dcpleung
Copy link
Member

This adds the SoC and board files to support testing Xtensa MPU via QEMU.

Depends on:

@zephyrbot
Copy link
Collaborator

zephyrbot commented Apr 24, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_xtensa DNM This PR should not be merged (Do Not Merge) labels Apr 24, 2024
@dcpleung dcpleung force-pushed the xtensa/sample_controller32_mpu branch from c145dd0 to f6d2e06 Compare April 24, 2024 18:26
@dcpleung dcpleung force-pushed the xtensa/sample_controller32_mpu branch from f6d2e06 to 39ae927 Compare June 11, 2024 18:51
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Jun 11, 2024
@dcpleung dcpleung marked this pull request as ready for review June 11, 2024 18:54
@zephyrbot zephyrbot added the area: Xtensa Xtensa Architecture label Jun 11, 2024
@dcpleung dcpleung force-pushed the xtensa/sample_controller32_mpu branch 2 times, most recently from 7a73d86 to fc7f52c Compare June 12, 2024 17:03
@dcpleung dcpleung force-pushed the xtensa/sample_controller32_mpu branch from fc7f52c to 6049fab Compare June 12, 2024 19:15
Copy link
Member

@cfriedt cfriedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just some cache API testsuite failing

@dcpleung
Copy link
Member Author

The cache failure is due to #72775 which is on the board apollo4p_blue_kxr_evb and unrelated to this.

nashif
nashif previously approved these changes Jun 14, 2024
@nashif nashif force-pushed the xtensa/sample_controller32_mpu branch from 6049fab to 97dfb29 Compare June 14, 2024 12:24
andyross
andyross previously approved these changes Jun 14, 2024
Copy link
Contributor

@andyross andyross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

teburd
teburd previously approved these changes Jun 14, 2024
@dcpleung dcpleung dismissed stale reviews from teburd, andyross, and nashif via afe609b July 15, 2024 18:24
@dcpleung dcpleung force-pushed the xtensa/sample_controller32_mpu branch 2 times, most recently from afe609b to 33ade0e Compare July 15, 2024 20:56
teburd
teburd previously approved these changes Aug 12, 2024
@dcpleung
Copy link
Member Author

Rebased due to HAL SHA has been updated in main.

This is in preparation for adding another SoC where qemu_xtensa
is no longer valid choice. So use qemu_xtensa/dc233c as it is
the same as the old qemu_xtensa.

Signed-off-by: Daniel Leung <[email protected]>
@dcpleung dcpleung force-pushed the xtensa/sample_controller32_mpu branch from 1e8d98e to 6052dec Compare September 25, 2024 23:53
Add sample_controller32 for Xtensa which has MPU.

Signed-off-by: Daniel Leung <[email protected]>
This adds the necessary bit to enable testing Xtensa MPU on
QEMU.

Signed-off-by: Daniel Leung <[email protected]>
Copy link
Member

@ceolin ceolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@aescolar aescolar merged commit 907a3bf into zephyrproject-rtos:main Oct 2, 2024
25 checks passed
@dcpleung dcpleung deleted the xtensa/sample_controller32_mpu branch October 2, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Xtensa Xtensa Architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants