Litex: clock: Undefined behavior due to unchecked return code #71728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franc0is
requested review from
mateusz-holenko,
kgugala and
pgielda
as code owners
franc0is
changed the title
franc0is
force-pushed
the
fbo-4
branch
2 times, most recently
from
7d5bec3
to
47256b2
Compare
|
Please rebase to retrigger CI @mateusz-holenko @kgugala please take a look |
mateusz-holenko
approved these changes
Jun 3, 2024
Found via static analysis. Two separate error paths where failing to check the return code leads to undefined behavior: 1. In `litex_clk_get_phase`, the divider stays set to 0 when `litex_clk_get_clkout_divider` errors out, which leads to a division by 0. 2. In `litex_clk_calc_duty_normal`, the `duty` struct is used uninitialized if `litex_clk_get_duty_cycle` errors out. In both case, checking the return code and returning early resolves the issue. Signed-off-by: François Baldassari <[email protected]>
|
rebased to trigger CI |
maass-hamburg
approved these changes
Jun 10, 2024
|
re-assigning as per recent update to MAINTAINERS.yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via static analysis. Two separate error paths where failing to check the return code leads to undefined behavior:
litex_clk_get_phase, the divider stays set to 0 whenlitex_clk_get_clkout_dividererrors out, which leads to a division by 0.litex_clk_calc_duty_normal, thedutystruct is used uninitialized iflitex_clk_get_duty_cycleerrors out.In both case, checking the return code and returning early resolves the issue.