Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: opentitan: update manifest format #70122

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ngm0
Copy link
Contributor

@ngm0 ngm0 commented Mar 12, 2024

Fix calculation of the app entry point.

@ngm0
Copy link
Contributor Author

ngm0 commented Mar 12, 2024

@snematbakhsh PTAL (apologies for the churn, github n00b here)

soc/lowrisc/opentitan/rom_header.S Outdated Show resolved Hide resolved
soc/lowrisc/opentitan/rom_header.S Outdated Show resolved Hide resolved
soc/lowrisc/opentitan/rom_header.S Outdated Show resolved Hide resolved
soc/lowrisc/opentitan/rom_header.S Outdated Show resolved Hide resolved
soc/lowrisc/opentitan/rom_header.S Outdated Show resolved Hide resolved
@snematbakhsh
Copy link
Collaborator

There are no committer reviewers on this PR, I think you can add them by clicking "Start Review" or similar.

@ngm0
Copy link
Contributor Author

ngm0 commented Mar 13, 2024

@nordicjm @ycsin could you help route this change for approval? (i'm unable to manually request a review).

@ycsin ycsin added the area: RISCV RISCV Architecture (32-bit & 64-bit) label Mar 14, 2024
@ycsin
Copy link
Member

ycsin commented Mar 14, 2024

Looks like the bot somehow didn't apply any label to this PR? cc @nashif @kartben

@ycsin
Copy link
Member

ycsin commented Mar 14, 2024

These files currently do not have a codeowner, maybe @snematbakhsh wants to be the owner?

@snematbakhsh
Copy link
Collaborator

These files currently do not have a codeowner, maybe @snematbakhsh wants to be the owner?

Sure, I will put up a PR today to make it so.

snematbakhsh
snematbakhsh previously approved these changes Mar 14, 2024
@fkokosinski fkokosinski self-assigned this Mar 20, 2024
Copy link
Member

@fkokosinski fkokosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI errors seem unrelated (nRF boards).

@ngm0
Copy link
Contributor Author

ngm0 commented Mar 27, 2024

seem like transient infra errors, ok to merge?

Fix calculation of the app entry point.

Signed-off-by: nagendra modadugu <[email protected]>
@kartben
Copy link
Collaborator

kartben commented Jun 7, 2024

rebased to trigger CI

@nashif nashif merged commit 161c56f into zephyrproject-rtos:main Jun 7, 2024
71 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: RISCV RISCV Architecture (32-bit & 64-bit) platform: OpenTitan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants