Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: wifi: add nxp wifi shim driver support #69541

Closed
wants to merge 2,150 commits into from
Closed

drivers: wifi: add nxp wifi shim driver support #69541

wants to merge 2,150 commits into from

Conversation

fengming-ye
Copy link
Contributor

No description provided.

@zephyrbot zephyrbot added the area: Wi-Fi Wi-Fi label Feb 28, 2024
@zephyrbot zephyrbot added platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP area: Devicetree Binding PR modifies or adds a Device Tree binding labels Feb 28, 2024
@fengming-ye fengming-ye force-pushed the feature/nxp_wifi_driver branch 3 times, most recently from e338bdb to e02717d Compare February 28, 2024 07:18
danieldegrasse
danieldegrasse reviewed Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@danieldegrasse danieldegrasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment here- we should add some form of support to a board in tree (I'd suggest the RT1170 EVKB or RT1060 EVKB) to move this PR forwards. I'm also aware we will need to add HAL side support for this driver in order to enable it to merge, so I am going to mark this PR as DMN until that point

drivers/wifi/nxp/Kconfig.nxp Outdated
config NET_SOCKETS_POLL_MAX
default 8

config ZEPHYR
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to drop this Kconfig, and rely on __ZEPHYR__ in modules that need to identify they are compiling targeting Zephyr

drivers/wifi/nxp/Kconfig.nxp
default y

config NXP_WIFI_CUSTOM
bool "Custom NXP Wi-Fi part"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a help string here expanding on when this feature would be used?

drivers/wifi/nxp/Kconfig.nxp Outdated
endchoice

config NXP_WIFI_SHELL
bool "nxpWiFi shell"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool "nxpWiFi shell"
bool "NXP WiFi shell"

drivers/wifi/nxp/Kconfig.nxp Outdated

config NXP_WIFI_SHELL
bool "nxpWiFi shell"
default n
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default n is redundant, please remove

drivers/wifi/nxp/Kconfig.nxp Outdated
default n
depends on SHELL
help
Enable nxpWiFi shell
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more help text here specifying what will be added when the user enables CONFIG_NXP_WIFI_SHELL

drivers/wifi/nxp/Kconfig.nxp Outdated
bool
prompt "Debug build"
depends on WIFI_LOG_LEVEL_DBG
default n
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default n

drivers/wifi/nxp/Kconfig.nxp Outdated
bool
prompt "OS debug"
depends on NXP_WIFI_DEBUG_BUILD
default n
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default n

drivers/wifi/nxp/Kconfig.nxp Outdated
bool
prompt "NET debug"
depends on NXP_WIFI_DEBUG_BUILD
default n
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default n

drivers/wifi/nxp/nxp_wifi_drv.c Outdated
}
#if (CONFIG_WIFI_MGMT_SCAN_SSID_FILT_MAX > 0)
if (params->ssids[0]) {
strcpy(wlan_scan_params_v2.ssid[0], params->ssids[0]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a general comment, but can we use strncpy to avoid potential issues if one of these strings is not null terminated?

drivers/wifi/nxp/nxp_wifi_drv.c Outdated Show resolved Hide resolved
@danieldegrasse danieldegrasse added the DNM This PR should not be merged (Do Not Merge) label Feb 28, 2024
@dleach02 dleach02 marked this pull request as draft March 5, 2024 19:19
@fengming-ye fengming-ye force-pushed the feature/nxp_wifi_driver branch 3 times, most recently from e4c7e9d to 50460b4 Compare March 11, 2024 02:06
@fengming-ye fengming-ye deleted the feature/nxp_wifi_driver branch April 23, 2024 03:19
@zephyrbot
Copy link
Collaborator

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
babblesim_base BabbleSim/base@19d6242 BabbleSim/base@4bd907b BabbleSim/[email protected]
babblesim_ext_2G4_device_playback BabbleSim/ext_2G4_device_playback@85c6459 BabbleSim/ext_2G4_device_playback@abb48cd (master) BabbleSim/[email protected]
babblesim_ext_2G4_libPhyComv1 BabbleSim/ext_2G4_libPhyComv1@9018113 BabbleSim/ext_2G4_libPhyComv1@93f5eba BabbleSim/[email protected]
babblesim_ext_2G4_modem_BLE_simple BabbleSim/ext_2G4_modem_BLE_simple@809ab07 BabbleSim/ext_2G4_modem_BLE_simple@a38d2d2 BabbleSim/[email protected]
babblesim_ext_2G4_modem_magic BabbleSim/ext_2G4_modem_magic@cb70771 BabbleSim/ext_2G4_modem_magic@edfcda2 (master) BabbleSim/[email protected]
babblesim_ext_2G4_phy_v1 BabbleSim/ext_2G4_phy_v1@d47c6dd BabbleSim/ext_2G4_phy_v1@d8302b8 BabbleSim/[email protected]
bsim zephyrproject-rtos/babblesim-manifest@384a091 (v2.1.1) zephyrproject-rtos/babblesim-manifest@68f6282 (v2.2) zephyrproject-rtos/[email protected]
hal_espressif zephyrproject-rtos/hal_espressif@67fa60b zephyrproject-rtos/hal_espressif@dddb7cf (zephyr) zephyrproject-rtos/[email protected]
hal_ethos_u zephyrproject-rtos/hal_ethos_u@90ada2e zephyrproject-rtos/hal_ethos_u@8e2cf75 (main) zephyrproject-rtos/[email protected]
hal_nordic zephyrproject-rtos/hal_nordic@daf8752 zephyrproject-rtos/hal_nordic@827224f (master) zephyrproject-rtos/[email protected]
hal_nuvoton zephyrproject-rtos/hal_nuvoton@68a91bb zephyrproject-rtos/hal_nuvoton@34efb92 (master) zephyrproject-rtos/[email protected]
hal_nxp zephyrproject-rtos/hal_nxp@ef50604 zephyrproject-rtos/hal_nxp@cd046fa (master) zephyrproject-rtos/[email protected]
hal_silabs zephyrproject-rtos/hal_silabs@59c6c6e zephyrproject-rtos/hal_silabs@442d0fb (master) zephyrproject-rtos/[email protected]
hal_st zephyrproject-rtos/hal_st@0643d20 zephyrproject-rtos/hal_st@b77157f (master) zephyrproject-rtos/[email protected]
hostap zephyrproject-rtos/hostap@dee924c zephyrproject-rtos/hostap@81bdd83 (main) zephyrproject-rtos/[email protected]
lvgl zephyrproject-rtos/lvgl@2b76c64 zephyrproject-rtos/lvgl@2b498e6 (zephyr) zephyrproject-rtos/[email protected]
mcuboot zephyrproject-rtos/mcuboot@8b4c70a zephyrproject-rtos/mcuboot@24ac8cc zephyrproject-rtos/[email protected]
net-tools zephyrproject-rtos/net-tools@3a677d3 zephyrproject-rtos/net-tools@cd2eb18 zephyrproject-rtos/[email protected]
nrf_hw_models zephyrproject-rtos/nrf_hw_models@52d0b4b zephyrproject-rtos/nrf_hw_models@123d37d zephyrproject-rtos/[email protected]
openthread zephyrproject-rtos/openthread@7761b81 zephyrproject-rtos/openthread@49c59ec (main) zephyrproject-rtos/[email protected]
percepio zephyrproject-rtos/percepio@0fbc5b7 zephyrproject-rtos/percepio@7f6fb3f (zephyr) zephyrproject-rtos/[email protected]
segger zephyrproject-rtos/segger@9d01912 zephyrproject-rtos/segger@b011c45 (master) zephyrproject-rtos/[email protected]
sof zephyrproject-rtos/sof@3e70d03 zephyrproject-rtos/sof@c11a318 (zephyr) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldegrasse danieldegrasse danieldegrasse left review comments

@gannicus-gj gannicus-gj gannicus-gj approved these changes

@jukkar jukkar Awaiting requested review from jukkar jukkar is a code owner

@Kludentwo Kludentwo Awaiting requested review from Kludentwo

@krish2718 krish2718 Awaiting requested review from krish2718

@rlubos rlubos Awaiting requested review from rlubos rlubos is a code owner

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108 mmahadevan108 is a code owner

@dleach02 dleach02 Awaiting requested review from dleach02 dleach02 is a code owner

@bperseghetti bperseghetti Awaiting requested review from bperseghetti

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@decsny decsny Awaiting requested review from decsny

@galak galak Awaiting requested review from galak galak is a code owner

@manuargue manuargue Awaiting requested review from manuargue manuargue is a code owner

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@avisconti avisconti Awaiting requested review from avisconti avisconti will be requested when the pull request is marked ready for review avisconti is a code owner

@thedjnK thedjnK Awaiting requested review from thedjnK thedjnK will be requested when the pull request is marked ready for review thedjnK is a code owner

@jimmyzhe jimmyzhe Awaiting requested review from jimmyzhe jimmyzhe will be requested when the pull request is marked ready for review jimmyzhe is a code owner

@alexanderwachter alexanderwachter Awaiting requested review from alexanderwachter alexanderwachter will be requested when the pull request is marked ready for review alexanderwachter is a code owner

@yonsch yonsch Awaiting requested review from yonsch yonsch will be requested when the pull request is marked ready for review yonsch is a code owner

@anangl anangl Awaiting requested review from anangl anangl will be requested when the pull request is marked ready for review anangl is a code owner

@MulinChao MulinChao Awaiting requested review from MulinChao MulinChao will be requested when the pull request is marked ready for review MulinChao is a code owner

@ChiHuaL ChiHuaL Awaiting requested review from ChiHuaL ChiHuaL will be requested when the pull request is marked ready for review ChiHuaL is a code owner

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen henrikbrixandersen will be requested when the pull request is marked ready for review henrikbrixandersen is a code owner

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan iuliana-prodan will be requested when the pull request is marked ready for review iuliana-prodan is a code owner

@sylvioalves sylvioalves Awaiting requested review from sylvioalves sylvioalves will be requested when the pull request is marked ready for review sylvioalves is a code owner

@dcpleung dcpleung Awaiting requested review from dcpleung dcpleung will be requested when the pull request is marked ready for review dcpleung is a code owner

@aaillet aaillet Awaiting requested review from aaillet aaillet will be requested when the pull request is marked ready for review aaillet is a code owner

@albertofloyd albertofloyd Awaiting requested review from albertofloyd albertofloyd will be requested when the pull request is marked ready for review albertofloyd is a code owner

@ssekar15 ssekar15 Awaiting requested review from ssekar15 ssekar15 will be requested when the pull request is marked ready for review ssekar15 is a code owner

@carlescufi carlescufi Awaiting requested review from carlescufi carlescufi will be requested when the pull request is marked ready for review carlescufi is a code owner

@JiafeiPan JiafeiPan Awaiting requested review from JiafeiPan JiafeiPan will be requested when the pull request is marked ready for review JiafeiPan is a code owner

@nandojve nandojve Awaiting requested review from nandojve nandojve will be requested when the pull request is marked ready for review nandojve is a code owner

@loicpoulain loicpoulain Awaiting requested review from loicpoulain loicpoulain will be requested when the pull request is marked ready for review loicpoulain is a code owner

@mniestroj mniestroj Awaiting requested review from mniestroj mniestroj will be requested when the pull request is marked ready for review mniestroj is a code owner

@nordic-krch nordic-krch Awaiting requested review from nordic-krch nordic-krch will be requested when the pull request is marked ready for review nordic-krch is a code owner

@ydamigos ydamigos Awaiting requested review from ydamigos ydamigos will be requested when the pull request is marked ready for review ydamigos is a code owner

@uLipe uLipe Awaiting requested review from uLipe uLipe will be requested when the pull request is marked ready for review uLipe is a code owner

@tbursztyka tbursztyka Awaiting requested review from tbursztyka tbursztyka will be requested when the pull request is marked ready for review tbursztyka is a code owner

@nashif nashif Awaiting requested review from nashif nashif will be requested when the pull request is marked ready for review nashif is a code owner

@gdengi gdengi Awaiting requested review from gdengi gdengi will be requested when the pull request is marked ready for review gdengi is a code owner

@valeriosetti valeriosetti Awaiting requested review from valeriosetti valeriosetti will be requested when the pull request is marked ready for review valeriosetti is a code owner

@bbilas bbilas Awaiting requested review from bbilas bbilas will be requested when the pull request is marked ready for review bbilas is a code owner

@gmarull gmarull Awaiting requested review from gmarull gmarull will be requested when the pull request is marked ready for review gmarull is a code owner

@LucasTambor LucasTambor Awaiting requested review from LucasTambor LucasTambor will be requested when the pull request is marked ready for review LucasTambor is a code owner

@ceolin ceolin Awaiting requested review from ceolin ceolin will be requested when the pull request is marked ready for review ceolin is a code owner

@mbolivar-ampere mbolivar-ampere Awaiting requested review from mbolivar-ampere mbolivar-ampere will be requested when the pull request is marked ready for review mbolivar-ampere is a code owner

@ankuns ankuns Awaiting requested review from ankuns ankuns will be requested when the pull request is marked ready for review ankuns is a code owner

@andy-liu-telink andy-liu-telink Awaiting requested review from andy-liu-telink andy-liu-telink will be requested when the pull request is marked ready for review andy-liu-telink is a code owner

@fgrandel fgrandel Awaiting requested review from fgrandel fgrandel will be requested when the pull request is marked ready for review fgrandel is a code owner

@GTLin08 GTLin08 Awaiting requested review from GTLin08 GTLin08 will be requested when the pull request is marked ready for review GTLin08 is a code owner

@de-nordic de-nordic Awaiting requested review from de-nordic de-nordic will be requested when the pull request is marked ready for review de-nordic is a code owner

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV GeorgeCGV will be requested when the pull request is marked ready for review GeorgeCGV is a code owner

@talih0 talih0 Awaiting requested review from talih0 talih0 will be requested when the pull request is marked ready for review talih0 is a code owner

@teburd teburd Awaiting requested review from teburd teburd will be requested when the pull request is marked ready for review teburd is a code owner

@abonislawski abonislawski Awaiting requested review from abonislawski abonislawski will be requested when the pull request is marked ready for review abonislawski is a code owner

@kv2019i kv2019i Awaiting requested review from kv2019i kv2019i will be requested when the pull request is marked ready for review kv2019i is a code owner

@marcinszkudlinski marcinszkudlinski Awaiting requested review from marcinszkudlinski marcinszkudlinski will be requested when the pull request is marked ready for review marcinszkudlinski is a code owner

@karstenkoenig karstenkoenig Awaiting requested review from karstenkoenig karstenkoenig will be requested when the pull request is marked ready for review karstenkoenig is a code owner

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic alwa-nordic will be requested when the pull request is marked ready for review alwa-nordic is a code owner

@jhedberg jhedberg Awaiting requested review from jhedberg jhedberg will be requested when the pull request is marked ready for review jhedberg is a code owner

@Vudentz Vudentz Awaiting requested review from Vudentz Vudentz will be requested when the pull request is marked ready for review Vudentz is a code owner

@aescolar aescolar Awaiting requested review from aescolar aescolar will be requested when the pull request is marked ready for review aescolar is a code owner

@daor-oti daor-oti Awaiting requested review from daor-oti daor-oti will be requested when the pull request is marked ready for review daor-oti is a code owner

Assignees

@jukkar jukkar

Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: Wi-Fi Wi-Fi manifest manifest-babblesim_base manifest-babblesim_ext_2G4_device_playback manifest-babblesim_ext_2G4_libPhyComv1 manifest-babblesim_ext_2G4_modem_BLE_simple manifest-babblesim_ext_2G4_modem_magic manifest-babblesim_ext_2G4_phy_v1 manifest-bsim manifest-hal_espressif manifest-hal_ethos_u manifest-hal_nordic manifest-hal_nuvoton manifest-hal_nxp manifest-hal_silabs manifest-hal_st manifest-hostap manifest-lvgl manifest-mcuboot manifest-net-tools manifest-nrf_hw_models manifest-openthread manifest-percepio manifest-segger manifest-sof platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.