drivers: gpio: pcal64xxa: give semaphore in case of error #68813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMarteng
reviewed
Feb 9, 2024
Nice catch of this bug! |
vgeneves
force-pushed
the
pcal64xxa
branch
2 times, most recently
from
6806964
to
10d2905
Compare
zephyrbot
added
the
Trivial
henrikbrixandersen
approved these changes
Feb 24, 2024
|
Hi @MrMarteng, @mnkp could you take a look at the last version. Thanks |
kartben
approved these changes
May 3, 2024
vgeneves
force-pushed
the
pcal64xxa
branch
2 times, most recently
from
944f3be
to
410e78e
Compare
In function pcal64xxa_process_input, lock was not released in case of error when calling inputs_read. This was causing an infinite wait in the following calls of functions using I2C bus. Signed-off-by: Vincent Geneves <[email protected]>
|
rebased (once more) to trigger stuck CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In function pcal64xxa_process_input, lock was not released in case of error when calling inputs_read.
This was causing an infinite wait in the following calls of functions using I2C bus.