-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: zbus: benchmark: complete refactoring and add msg subscriber to benchmark #64524
samples: zbus: benchmark: complete refactoring and add msg subscriber to benchmark #64524
Conversation
f0f482e
to
5e4f517
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments from my side -- fwiw it would help if the PR would be split in smaller chunks as there seems to be several changes here beyond just "adding message subscribers to benchmark", making the review more difficult than necessary. Thanks!
Thank you for the comments. I am aware that it is better to separate the changes. However, it would take so long to be accepted. My PRs usually take three weeks or more to be added. If I split that into 3 PRs, it would take two months. I am trying my best here; the bigger PRs are more challenging to review. Yet, it makes my life easier. My baby boy, the Ph.D., and my work take almost all the time I have to contribute. I ask you folks for patience with my big PRs. As soon as things go lighter here, I will separate that. Sounds good? |
5e4f517
to
751f570
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add changes requested by @kartben.
@kartben, is there anything I should change here to make that okay for merging? |
Hi @rodrigopex -- I will try to find time to review this but to clarify I was not asking for several PRs but rather to try and isolate the changes in several commits (but all in the same PR of course), so that reviewing the changes is easier. Here it looks like a fairly significant refactoring intertwined with what might be some less impactful changes, and it would have been great to be able to review the former while only quickly looking at the latter. |
751f570
to
9438699
Compare
9438699
to
53e8a31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested have been attended, @fabiobaltieri.
The benchmark sample did not contemplate message subscribers. It adds the msg subscribers and improves the organization of the project. Signed-off-by: Rodrigo Peixoto <[email protected]>
53e8a31
to
b2acf9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested have been attended, @fabiobaltieri.
Thank you for reviewing that, guys. Let's keep going! |
Note
This PR rewrites the whole benchmark sample to improve code reuse and macro calls.
The benchmark sample did not contemplate message subscribers. It adds the msg subscribers and improves the organization of the project.