Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: zbus: benchmark: complete refactoring and add msg subscriber to benchmark #64524

Merged

Conversation

rodrigopex
Copy link
Contributor

@rodrigopex rodrigopex commented Oct 28, 2023

Note

This PR rewrites the whole benchmark sample to improve code reuse and macro calls.

The benchmark sample did not contemplate message subscribers. It adds the msg subscribers and improves the organization of the project.

Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments from my side -- fwiw it would help if the PR would be split in smaller chunks as there seems to be several changes here beyond just "adding message subscribers to benchmark", making the review more difficult than necessary. Thanks!

samples/subsys/zbus/benchmark/CMakeLists.txt Outdated Show resolved Hide resolved
samples/subsys/zbus/benchmark/Kconfig Outdated Show resolved Hide resolved
@rodrigopex
Copy link
Contributor Author

@kartben

some comments from my side -- fwiw it would help if the PR would be split in smaller chunks as there seems to be several changes here beyond just "adding message subscribers to benchmark", making the review more difficult than necessary. Thanks!

Thank you for the comments. I am aware that it is better to separate the changes. However, it would take so long to be accepted. My PRs usually take three weeks or more to be added. If I split that into 3 PRs, it would take two months. I am trying my best here; the bigger PRs are more challenging to review. Yet, it makes my life easier. My baby boy, the Ph.D., and my work take almost all the time I have to contribute. I ask you folks for patience with my big PRs. As soon as things go lighter here, I will separate that. Sounds good?

Copy link
Contributor Author

@rodrigopex rodrigopex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changes requested by @kartben.

@rodrigopex
Copy link
Contributor Author

@kartben, is there anything I should change here to make that okay for merging?

@rodrigopex rodrigopex changed the title samples: zbus: benchmark: add msg subscriber to benchmark samples: zbus: benchmark: complete refactoring and add msg subscriber to benchmark Nov 27, 2023
@rodrigopex rodrigopex added the dev-review To be discussed in dev-review meeting label Nov 27, 2023
@kartben
Copy link
Collaborator

kartben commented Dec 6, 2023

@kartben

some comments from my side -- fwiw it would help if the PR would be split in smaller chunks as there seems to be several changes here beyond just "adding message subscribers to benchmark", making the review more difficult than necessary. Thanks!

Thank you for the comments. I am aware that it is better to separate the changes. However, it would take so long to be accepted. My PRs usually take three weeks or more to be added. If I split that into 3 PRs, it would take two months. I am trying my best here; the bigger PRs are more challenging to review. Yet, it makes my life easier. My baby boy, the Ph.D., and my work take almost all the time I have to contribute. I ask you folks for patience with my big PRs. As soon as things go lighter here, I will separate that. Sounds good?

Hi @rodrigopex -- I will try to find time to review this but to clarify I was not asking for several PRs but rather to try and isolate the changes in several commits (but all in the same PR of course), so that reviewing the changes is easier. Here it looks like a fairly significant refactoring intertwined with what might be some less impactful changes, and it would have been great to be able to review the former while only quickly looking at the latter.

@rodrigopex rodrigopex closed this Dec 6, 2023
@rodrigopex rodrigopex reopened this Dec 6, 2023
@MaureenHelm MaureenHelm removed the dev-review To be discussed in dev-review meeting label Dec 6, 2023
pdgendt
pdgendt previously approved these changes Dec 7, 2023
samples/subsys/zbus/benchmark/Kconfig Outdated Show resolved Hide resolved
pdgendt
pdgendt previously approved these changes Dec 7, 2023
Copy link
Contributor Author

@rodrigopex rodrigopex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested have been attended, @fabiobaltieri.

pdgendt
pdgendt previously approved these changes Dec 7, 2023
The benchmark sample did not contemplate message subscribers. It adds
the msg subscribers and improves the organization of the project.

Signed-off-by: Rodrigo Peixoto <[email protected]>
Copy link
Contributor Author

@rodrigopex rodrigopex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested have been attended, @fabiobaltieri.

@fabiobaltieri fabiobaltieri merged commit 2f230e8 into zephyrproject-rtos:main Dec 12, 2023
17 checks passed
@rodrigopex rodrigopex deleted the zbus_benchmarck_msg_sub branch December 12, 2023 11:41
@rodrigopex
Copy link
Contributor Author

Thank you for reviewing that, guys. Let's keep going!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants