Hostap module glue code #64500
Merged
Hostap module glue code #64500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukkar
added
In progress
zephyrbot
added
manifest
manifest-hostap
DNM
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
jukkar
force-pushed
the
hostap-add-mgmt-thread
branch
from
d2c20a0
to
5ed39e0
Compare
jukkar
force-pushed
the
hostap-add-mgmt-thread
branch
from
5ed39e0
to
4c8afa7
Compare
jukkar
force-pushed
the
hostap-add-mgmt-thread
branch
from
4c8afa7
to
bb0834a
Compare
|
This update adds scanning support. |
jukkar
force-pushed
the
hostap-add-mgmt-thread
branch
from
bb0834a
to
cd5ffbf
Compare
|
Added initial |
|
Hi @jukkar , I am from NXP wifi team, when will you merge these wpa-supplicant changes into Zephyr? |
We would like to get more feedback from people about the PR. But if everything looks ok (please give feedback here), I can certainly start to prepare a version that is suitable for merging. There is the related PR at zephyrproject-rtos/hostap#2 that has the hostap changes also waiting a review. So I will most probably remove the native_sim wifi testing driver from this PR as it requires still more work and I can send it separately after the wpa_supplicant is merged. |
jukkar
force-pushed
the
hostap-add-mgmt-thread
branch
from
cd5ffbf
to
47d633d
Compare
|
Prepared a new version fixing CI. Also removed the native_sim wifi driver as it requires more work and can be submitted separately. |
jukkar
force-pushed
the
hostap-add-mgmt-thread
branch
4 times, most recently
from
c2e7644
to
1c6d8f2
Compare
jukkar
removed
In progress
|
I accidentally removed the DNM label as the corresponding hostap PR needs to be merged first, so adding it back. |
krish2718
reviewed
Jan 15, 2024
|
@dleach02 (or someone from NXP), please take a look. |
jukkar
force-pushed
the
hostap-add-mgmt-thread
branch
from
1c6d8f2
to
7fd3e4f
Compare
|
krish2718
previously approved these changes
Jan 23, 2024
dleach02
previously approved these changes
Jan 25, 2024
Add new files from hostap to Zephyr build. Add wifi mgmt thread that communicates with supplicant. Signed-off-by: Chaitanya Tata <[email protected]> Signed-off-by: Jukka Rissanen <[email protected]>
New hostap version available. Signed-off-by: Jukka Rissanen <[email protected]>
There is no need to hide the wpa_supplicant interface struct so add it directly to net_wifi_mgmt_offload struct. Signed-off-by: Jukka Rissanen <[email protected]>
Changed the names of the API functions between wpa_supplicant and Zephyr upper layers. For example replaced the z_ prefix by zephyr_ as the z_ is only meant for internal kernel functions. Changed the wpa_supplicant startup so that we do not poll but wait the network interface add event which then adds the network interfaces to the supplicant. Signed-off-by: Jukka Rissanen <[email protected]>
Tweaked the code to be more readable and align to Zephyr coding style. Signed-off-by: Jukka Rissanen <[email protected]>
If the DHCPv4 is disabled, then avoid linking warning about missing DHCPv4 functions. Also include dhcpv4.h so that the DHCPv4 function prototypes are found by the zephyr supplicant driver. Signed-off-by: Jukka Rissanen <[email protected]>
Zephyr requires that the name of the variable is not the same as the struct as seen by this warning: modules/hostap/src/supp_api.c:64:WARNING: Violation to rule 5.7 (Tag name should be unique) tag: wpa_supp_api_ctrl Signed-off-by: Jukka Rissanen <[email protected]>
Zephyr compliance checker does not like macros that have control structures like goto. So change the macro to align with this rule. Also rename the macro and remove the __ prefix as it not needed. Signed-off-by: Jukka Rissanen <[email protected]>
Compliance checker does not allow compile definitions without a Kconfig option. So add dummy values for time being. These should be removed at some point and replaced with properly namespaced options. Signed-off-by: Jukka Rissanen <[email protected]>
Some crypto Kconfig options were commented out, so remove them. These will be re-introduced later when adding crypto support properly. Signed-off-by: Jukka Rissanen <[email protected]>
jukkar
force-pushed
the
hostap-add-mgmt-thread
branch
from
7fd3e4f
to
a41925b
Compare
|
manifest file changed as the hostap module was updated |
krish2718
approved these changes
Jan 26, 2024
dleach02
approved these changes
Jan 26, 2024
fabiobaltieri
merged commit 64423e2
into
zephyrproject-rtos:main
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides interface glue code to hostap module in
modules/hostapdirectory. Crypto support is disabled.The example native_sim based example / testing wifi driver is still WIP and is sent in a separate PR after this one is merged.