input: add some initial keyboard matrix library stubs #64456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobaltieri
force-pushed
the
input-keyboard
branch
5 times, most recently
from
88b4ff3
to
2718825
Compare
fabiobaltieri
commented
Oct 26, 2023
drivers/input/input_kbd_matrix.h
Outdated
| struct input_kbd_matrix_common_data { | ||
| struct k_thread thread; | ||
|
|
||
| K_KERNEL_STACK_MEMBER(thread_stack, CONFIG_INPUT_KBD_THREAD_STACK_SIZE); |
There was a problem hiding this comment.
I finally understand why everyone puts a space before this one, checkpatch complains. Should really fix checkpatch, but Perl.
fabiobaltieri
requested review from
MulinChao,
ChiHuaL and
galak
as code owners
zephyrbot
added
area: Input
fabiobaltieri
force-pushed
the
input-keyboard
branch
from
2718825
to
05f102c
Compare
ChiHuaL
previously approved these changes
Oct 30, 2023
MulinChao
previously approved these changes
Oct 30, 2023
keith-zephyr
previously approved these changes
Oct 30, 2023
We currently have three keyboard scanning drivers in the code base (npcx, it8xxx2 and mchp_xec, last two yet to be converted to input). These have been largely copy pasted from each other and share a lot of the same structure and code. This PR lays a foundation to start decoupling feature from those drivers into a common code base, and it is heavily inspired by the current regulator common data/config one. Feature wise this only moves the thread struct, stack and initialization to the common code and declares the thread callback as the only API, but the intent is to move as much code as possible in there an only abstract device specific callbacks in the api structures. Signed-off-by: Fabio Baltieri <[email protected]>
|
Merge conflict, rebased. |
fabiobaltieri
dismissed stale reviews from keith-zephyr, MulinChao, and ChiHuaL
via
f8e018f
fabiobaltieri
force-pushed
the
input-keyboard
branch
from
05f102c
to
f8e018f
Compare
keith-zephyr
approved these changes
Oct 30, 2023
MulinChao
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up the work from #52355 and #42923, making this an internal library (similar to
i2c_bitbangorcan_mcan) rather than a subsystem api.We currently have three keyboard scanning drivers in the code base (npcx, it8xxx2 and mchp_xec, last two yet to be converted to input). These have been largely copy pasted from each other and share a lot of the same structure and code.
This PR lays a foundation to start decoupling feature from those drivers into a common code base, and it is heavily inspired by the current regulator common data/config one.
Feature wise this only moves the thread struct, stack and initialization to the common code and declares the thread callback as the only API, but the intent is to move as much code as possible in there an only abstract device specific callbacks in the api structures.