drivers: bluetooth: hci: Simplify SPI driver #64453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoZHel
requested review from
alwa-nordic,
jhedberg,
Vudentz,
erwango,
MaureenHelm and
galak
as code owners
zephyrbot
added
area: Shields
zephyrbot
requested review from
ABOSTM,
avisconti,
Desvauxm-st,
FRASTM,
gautierg-st,
GeorgeCGV,
hermabe,
jfischer-no and
kartben
erwango
requested changes
Oct 26, 2023
Use LOG_HEXDUMP_DBG for SPI message logging instead of printk. Signed-off-by: Ali Hozhabri <[email protected]>
carlescufi
requested review from
JordanYates
and removed request for
avisconti,
kartben,
Vudentz,
GeorgeCGV,
MaureenHelm,
jfischer-no and
galak
Remove redundant configure_cs as it is performed by SPI initialization. Signed-off-by: Ali Hozhabri <[email protected]>
HoZHel
force-pushed
the
hci_spi_driver_mods
branch
from
7c74dbe
to
2ecca9e
Compare
zephyrbot
requested review from
ABOSTM,
avisconti,
Desvauxm-st,
FRASTM,
gautierg-st,
GeorgeCGV,
jfischer-no,
jori-nordic and
kartben
HoZHel
force-pushed
the
hci_spi_driver_mods
branch
from
2ecca9e
to
9830cb6
Compare
erwango
reviewed
Oct 27, 2023
Modify SPI configuration to match the features introduced in PR zephyrproject-rtos#63437. Set the property "controller-data-delay-us" to zero for boards which are using BlueNRG-MS. Fix Chip Select configuration for stm32l562e_dk board. Signed-off-by: Ali Hozhabri <[email protected]>
HoZHel
force-pushed
the
hci_spi_driver_mods
branch
from
9830cb6
to
54c31e1
Compare
STM32L562 Discovery kit is not compatible with Bluetooth over USB application. Add missing information related to the BLE capability of this board. Signed-off-by: Ali Hozhabri <[email protected]>
Replace hard-coded values with suitable macros. Signed-off-by: Ali Hozhabri <[email protected]>
HoZHel
force-pushed
the
hci_spi_driver_mods
branch
from
54c31e1
to
37d7095
Compare
JordanYates
approved these changes
Oct 28, 2023
alwa-nordic
reviewed
Oct 30, 2023
| @@ -10,7 +10,7 @@ tests: | |||
| - usb | |||
| - bluetooth | |||
| # FIXME: exclude due to build error | |||
| platform_exclude: 96b_carbon | |||
| platform_exclude: 96b_carbon stm32l562e_dk | |||
There was a problem hiding this comment.
Is this because of USB?
There was a problem hiding this comment.
Yes. Since the platform is running a 2-chip configuration where the controller part is running on BlueNRG-MS using an SPI interface, and the STM32L4xxxx is running the host part connected via SPI to the controller, therefore, the hci_usb protocol does not apply to this platform.
jhedberg
approved these changes
Oct 30, 2023
erwango
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used
LOG_HEXDUMP_DBGfor SPI message logging instead ofprintk.Removed redundant
configure_csas it is performed by SPI initialization.Modified SPI configuration to match the features introduced in PR #63437.