samples/bluetooth/hci_rpmsg: Allow building for simulated nrf5340 #64385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow building these samples for the simulted nrf5340 net core. Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
force-pushed
the
enable_hci_rpmsg_bsim
branch
from
efb7ae5
to
7276a29
Compare
aescolar
requested review from
jhedberg,
Vudentz,
alwa-nordic and
sjanc
as code owners
zephyrbot
requested review from
asbjornsabo,
hermabe,
kartben,
nashif and
Thalley
jhedberg
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Looks fine, but note that this conflicts with #64391
@carlescufi FYI
Thalley
approved these changes
Oct 26, 2023
Yep, whoever is merged after the other will need to handle the merge conflicts, which should not be specially difficult :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow building these samples for the simulted nrf5340 net core.