nrf53_bsim: Get IPC shared memory buffer size from DT #64320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruithofa
previously approved these changes
Oct 24, 2023
cvinayak
requested changes
Oct 25, 2023
Before we were defining the buffer in the runner context which is simpler and less error prone, but it had a hardcoded size decoupled from DT as it could not be based on DT information. Instead, let's allocate the buffer in the application core image. This allows us to size it based on the device tree configuration. Note that this then requires the application core image to be present during link time of the final executable when the IPC subsystem is used. Signed-off-by: Alberto Escolar Piedras <[email protected]>
cvinayak
approved these changes
Oct 25, 2023
kruithofa
approved these changes
Oct 25, 2023
jhedberg
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were defining the buffer in the runner context which is simpler and less error prone, but it had a hardcoded size decoupled from DT as it could not be based on DT information.
Instead, let's allocate the buffer in the application core image. This allows us to size it based on the device tree configuration.
Note that this then requires the application core image to be present during link time of the final executable when the IPC subsystem is used.