Bluetooth: ISO: Minor fixes for ISO shell #64244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If CONFIG_BT_ISO_TEST_PARAMS=y then the CIG and BIG create params was not properly initialized. Modified the TX for BIS and CIS to be more similar Added a timeout on the buffer to avoid any potentional deadlocks. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
requested review from
alwa-nordic,
jhedberg and
Vudentz
as code owners
zephyrbot
requested review from
asbjornsabo,
hermabe,
jori-nordic,
sjanc and
theob-pro
kruithofa
previously approved these changes
Oct 23, 2023
kruithofa
force-pushed
the
iso_shell_fixes
branch
from
f42ba17
to
877bee2
Compare
Thalley
force-pushed
the
iso_shell_fixes
branch
from
877bee2
to
f42ba17
Compare
kruithofa
approved these changes
Oct 26, 2023
jhedberg
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If CONFIG_BT_ISO_TEST_PARAMS=y then the CIG and BIG create params was not properly initialized.
Modified the TX for BIS and CIS to be more similar
Added a timeout on the buffer to avoid any potentional deadlocks.