drivers: rtc: new maxim ds1307 rtc driver #64219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
bjarki-andreasen,
MaureenHelm and
microbuilder
arun-mani-tech
force-pushed
the
rtc/ds1307
branch
4 times, most recently
from
0b8eaae
to
324ec8c
Compare
|
@bjarki-trackunit Kindly have a look |
bjarki-andreasen
requested changes
Oct 24, 2023
arun-mani-tech
force-pushed
the
rtc/ds1307
branch
2 times, most recently
from
b428951
to
e5a717e
Compare
|
@bjarki-trackunit Please review |
|
Looks good, last request, could you run the RTC API test suite? (ignore the y2k test failing once you run it) |
|
@bjarki-trackunit I ran RTC API test_suite. All checks are passed except yday, isdst, nsec. Because this chip does not support that |
bjarki-andreasen
requested changes
Oct 26, 2023
arun-mani-tech
force-pushed
the
rtc/ds1307
branch
from
e5a717e
to
0773194
Compare
|
@bjarki-trackunit Please revisit |
|
@bjarki-trackunit Thanks for the review |
arun-mani-tech
force-pushed
the
rtc/ds1307
branch
from
0773194
to
2665551
Compare
fabiobaltieri
previously approved these changes
Oct 26, 2023
Added rtc driver for ds1307. It allows to read and set the date and time Signed-off-by: Arunmani Alagarsamy <[email protected]>
arun-mani-tech
force-pushed
the
rtc/ds1307
branch
from
2665551
to
5dcb7b2
Compare
|
@bjarki-trackunit @fabiobaltieri Gentle ping! |
bjarki-andreasen
approved these changes
Oct 27, 2023
fabiobaltieri
approved these changes
Oct 27, 2023
No need to ping, GitHub notifications already do it for you. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rtc driver for ds1307. It allows to read and set the date and time