Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mulitple updates to the nrf5340bsim target and other improvements #64134

Merged
merged 7 commits into from
Oct 26, 2023

Conversation

aescolar
Copy link
Member

@aescolar aescolar commented Oct 19, 2023

Multiple improvements to the nrf5340bsim and some tangential improvements which enable much more functionality in this target.

  • Adds support to nrf53 sync_rtc in simulation
  • Both the nrf53_sync_rtc and drivers/mbox samples are adapted to support this simulated target, and as a bonus their build is converted to sysbuild, and the samples get a runtime test.
  • The nrf53bsim docs get a paragraph about using sysbuild.
  • To enable these the latest nrf hw models are fetched.

@zephyrbot
Copy link
Collaborator

zephyrbot commented Oct 19, 2023

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrf_hw_models zephyrproject-rtos/nrf_hw_models@f7842d7 zephyrproject-rtos/nrf_hw_models@90f4484 zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@aescolar aescolar changed the title Rtc sync pr Mulitple updates to the nrf5340bsim target and other improvements Oct 19, 2023
@aescolar aescolar added this to the v3.6.0 milestone Oct 19, 2023
@aescolar aescolar force-pushed the rtc_sync_pr branch 2 times, most recently from 0c55b44 to 3c7830b Compare October 20, 2023 14:10
tejlmand
tejlmand previously approved these changes Oct 23, 2023
Copy link
Collaborator

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

Noticed a minor nit which has nothing to do with the changes in this PR, as the same issue exists in current implementation, but something that could be improved.

* Update the HW models module to
90f4484cbaec986ed253b4fe9649aa75e632de15

Including the following:
* 90f4484 nrf_dppi & dppi_hack: Add support for NRF_DPPI_ENDPOINT_

Note: This update requires hal_nordic/nrfx release 3.2

Signed-off-by: Alberto Escolar Piedras <[email protected]>
Add support for these two options in the simulated board.

Before these options were otherwise defined in the real
BOARD/SOC kconfig files, which meant samples/tests which
used them would not be able to build due to a kconfig error.

With this change they can both be selected, and the right
functionality is built in.

Signed-off-by: Alberto Escolar Piedras <[email protected]>
Add support for this sample in the simulated nrf5340

Signed-off-by: Alberto Escolar Piedras <[email protected]>
Convert this sample application build to sysbuild,
and update documentation.

Signed-off-by: Alberto Escolar Piedras <[email protected]>
Add a runtest for the simulated target.

Signed-off-by: Alberto Escolar Piedras <[email protected]>
And a link to an example sample and its sysbuild.cmake file

Signed-off-by: Alberto Escolar Piedras <[email protected]>
Let's delete the note which says OpenAMP is not supported
as it is now.

Signed-off-by: Alberto Escolar Piedras <[email protected]>
@carlescufi carlescufi merged commit f7f800c into zephyrproject-rtos:main Oct 26, 2023
20 checks passed
@aescolar aescolar deleted the rtc_sync_pr branch October 26, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants