Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth: Mesh: Enhance Provision speed over PB-ADV bearer #62331

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Bluetooth: Mesh: Enhance Provision speed over PB-ADV bearer #62331

merged 5 commits into from
Oct 20, 2023

Conversation

LingaoM
Copy link
Collaborator

@LingaoM LingaoM commented Sep 6, 2023 •
edited
Loading

@LingaoM LingaoM requested review from alxelax and removed request for PavelVPV, jhedberg, Vudentz, sjanc, wopu-ot and alwa-nordic September 6, 2023 08:49
@LingaoM LingaoM force-pushed the perral_adv branch 10 times, most recently from 162c67b to 5c7e2cd Compare September 7, 2023 03:08
@LingaoM LingaoM requested a review from jhedberg October 18, 2023 10:37
@fabiobaltieri fabiobaltieri added this to the v3.6.0 milestone Oct 18, 2023
@carlescufi carlescufi merged commit 7c7ea38 into zephyrproject-rtos:main Oct 20, 2023
21 checks passed
alxelax pushed a commit to alxelax/sdk-zephyr that referenced this pull request Nov 9, 2023
@LingaoM @alxelax
[nrf fromlist] Bluetooth: Mesh: Remove bits for adv tag
c461bd1 
since tag for buf single only, no need for bit, also for
save some memory for rfu.

Upstream PR: zephyrproject-rtos/zephyr#62331
Signed-off-by: Lingao Meng <[email protected]>
(cherry picked from commit b14d235)
alxelax pushed a commit to alxelax/sdk-zephyr that referenced this pull request Nov 9, 2023
@LingaoM @alxelax
[nrf fromlist] Bluetooth: Mesh: Rename adv relay to adv simultaneous
9d840b6 
Since notice that simultaneous advertising is not only used
by relay message, provision over pb-adv can also be used.
so it was changed to a more general name.

refs:zephyrproject-rtos/zephyr#48903

Upstream PR: zephyrproject-rtos/zephyr#62331
Signed-off-by: Lingao Meng <[email protected]>
(cherry picked from commit 141467a)
alxelax pushed a commit to alxelax/sdk-zephyr that referenced this pull request Nov 9, 2023
@LingaoM @alxelax
[nrf fromlist] Bluetooth: Mesh: Use system workqueue for dhkey gen
1cc6a16 
Since the default process dhkey gen in bt rx, will block send
Trans Ack, cause peer device send more package.

Upstream PR: zephyrproject-rtos/zephyr#62331
Signed-off-by: Lingao Meng <[email protected]>
(cherry picked from commit 1b22324)
alxelax pushed a commit to alxelax/sdk-zephyr that referenced this pull request Nov 9, 2023
@LingaoM @alxelax
[nrf fromlist] Bluetooth: Mesh: Move ext adv sector to vector
5886601 
Obviously, it looks obscure by putting it in a sector,
so, let's move to vector.

refs: zephyrproject-rtos/zephyr#57883

Upstream PR: zephyrproject-rtos/zephyr#62331
Signed-off-by: Lingao Meng <[email protected]>
(cherry picked from commit c2b2641)
alxelax pushed a commit to alxelax/sdk-zephyr that referenced this pull request Nov 9, 2023
@PavelVPV @alxelax
[nrf fromlist] bsim: bluetooth: mesh: Increase Net Transmit Count val…
527dc69 
…ue on the node

This is to increase probability of reception of responses (Config Status
messages) from the node when the provisioner sends a Set message and the
node response with a Status message at the same time so that the message
collide.

Upstream PR: zephyrproject-rtos/zephyr#62331
Signed-off-by: Pavel Vasilyev <[email protected]>
(cherry picked from commit 7c7ea38)
nordicjm pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Nov 13, 2023
@LingaoM @nordicjm
[nrf fromlist] Bluetooth: Mesh: Remove bits for adv tag
2c3b9c4 
since tag for buf single only, no need for bit, also for
save some memory for rfu.

Upstream PR: zephyrproject-rtos/zephyr#62331
Signed-off-by: Lingao Meng <[email protected]>
(cherry picked from commit b14d235)
nordicjm pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Nov 13, 2023
@LingaoM @nordicjm
[nrf fromlist] Bluetooth: Mesh: Rename adv relay to adv simultaneous
4d33c79 
Since notice that simultaneous advertising is not only used
by relay message, provision over pb-adv can also be used.
so it was changed to a more general name.

refs:zephyrproject-rtos/zephyr#48903

Upstream PR: zephyrproject-rtos/zephyr#62331
Signed-off-by: Lingao Meng <[email protected]>
(cherry picked from commit 141467a)
nordicjm pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Nov 13, 2023
@LingaoM @nordicjm
[nrf fromlist] Bluetooth: Mesh: Use system workqueue for dhkey gen
d5bb75f 
Since the default process dhkey gen in bt rx, will block send
Trans Ack, cause peer device send more package.

Upstream PR: zephyrproject-rtos/zephyr#62331
Signed-off-by: Lingao Meng <[email protected]>
(cherry picked from commit 1b22324)
nordicjm pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Nov 13, 2023
@LingaoM @nordicjm
[nrf fromlist] Bluetooth: Mesh: Move ext adv sector to vector
9c6d0f8 
Obviously, it looks obscure by putting it in a sector,
so, let's move to vector.

refs: zephyrproject-rtos/zephyr#57883

Upstream PR: zephyrproject-rtos/zephyr#62331
Signed-off-by: Lingao Meng <[email protected]>
(cherry picked from commit c2b2641)
nordicjm pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Nov 13, 2023
@PavelVPV @nordicjm
[nrf fromlist] bsim: bluetooth: mesh: Increase Net Transmit Count val…
6dde669 
…ue on the node

This is to increase probability of reception of responses (Config Status
messages) from the node when the provisioner sends a Set message and the
node response with a Status message at the same time so that the message
collide.

Upstream PR: zephyrproject-rtos/zephyr#62331
Signed-off-by: Pavel Vasilyev <[email protected]>
(cherry picked from commit 7c7ea38)
alxelax added a commit to alxelax/zephyr that referenced this pull request Nov 22, 2023
@alxelax
Bluetooth:Mesh: allocate mesh max required buffer number
0c8ca57 
Since sending of public key was moved into system
work (zephyrproject-rtos#62331)
it uses the same context as a Host Tx buffer
allocator for gatt sending. Host cannot wait for
free buffer anymore. Mesh requires 4 buffers
to send max size frame(public key) during
provisioning.

Signed-off-by: Aleksandr Khromykh <[email protected]>
@alxelax alxelax mentioned this pull request Nov 22, 2023
Merged
alxelax added a commit to alxelax/zephyr that referenced this pull request Nov 22, 2023
@alxelax
Bluetooth: Mesh: allocate mesh max required buffer number
e5f3b64 
Since sending of public key was moved into system
work (zephyrproject-rtos#62331)
it uses the same context as a Host Tx buffer
allocator for gatt sending. Host cannot wait for
free buffer anymore. Mesh requires 4 buffers
to send max size frame(public key) during
provisioning.

Signed-off-by: Aleksandr Khromykh <[email protected]>
alxelax added a commit to alxelax/zephyr that referenced this pull request Nov 23, 2023
@alxelax
Bluetooth: Mesh: allocate mesh max required buffer number
c92e876 
Since sending of public key was moved into system
work (zephyrproject-rtos#62331)
it uses the same context as a Host Tx buffer
allocator for gatt sending. Host cannot wait for
free buffer anymore. Mesh requires 4 buffers
to send max size frame(public key) during
provisioning.

Signed-off-by: Aleksandr Khromykh <[email protected]>
alxelax added a commit to alxelax/zephyr that referenced this pull request Nov 23, 2023
@alxelax
Bluetooth: Mesh: allocate mesh max required buffer number
14da174 
Since sending of public key was moved into system
work (zephyrproject-rtos#62331)
it uses the same context as a Host Tx buffer
allocator for gatt sending. Host cannot wait for
free buffer anymore. Mesh requires 4 buffers
to send max size frame(public key) during
provisioning.

Signed-off-by: Aleksandr Khromykh <[email protected]>
carlescufi pushed a commit that referenced this pull request Nov 24, 2023
@alxelax @carlescufi
Bluetooth: Mesh: allocate mesh max required buffer number
3d37549 
Since sending of public key was moved into system
work (#62331)
it uses the same context as a Host Tx buffer
allocator for gatt sending. Host cannot wait for
free buffer anymore. Mesh requires 4 buffers
to send max size frame(public key) during
provisioning.

Signed-off-by: Aleksandr Khromykh <[email protected]>
coreboot-org-bot pushed a commit to coreboot/zephyr-cros that referenced this pull request Nov 24, 2023
@alxelax
Bluetooth: Mesh: allocate mesh max required buffer number
28c744a 
Since sending of public key was moved into system
work (zephyrproject-rtos/zephyr#62331)
it uses the same context as a Host Tx buffer
allocator for gatt sending. Host cannot wait for
free buffer anymore. Mesh requires 4 buffers
to send max size frame(public key) during
provisioning.

(cherry picked from commit 3d37549)

Original-Signed-off-by: Aleksandr Khromykh <[email protected]>
GitOrigin-RevId: 3d37549
Change-Id: I26bf2fddd13528cddf2f18a09e2dde6ac990e541
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5058943
Reviewed-by: Tristan Honscheid <[email protected]>
Tested-by: ChromeOS Prod (Robot) <[email protected]>
Tested-by: Tristan Honscheid <[email protected]>
Commit-Queue: Tristan Honscheid <[email protected]>
yunheQin pushed a commit to yunheQin/zephyr that referenced this pull request Dec 6, 2023
@alxelax @yunheQin
Bluetooth: Mesh: allocate mesh max required buffer number
94994f9 
Since sending of public key was moved into system
work (zephyrproject-rtos#62331)
it uses the same context as a Host Tx buffer
allocator for gatt sending. Host cannot wait for
free buffer anymore. Mesh requires 4 buffers
to send max size frame(public key) during
provisioning.

Signed-off-by: Aleksandr Khromykh <[email protected]>
panxxhub pushed a commit to panxxhub/zephyr that referenced this pull request Dec 7, 2023
@alxelax @panxxhub
Bluetooth: Mesh: allocate mesh max required buffer number
a1de746 
Since sending of public key was moved into system
work (zephyrproject-rtos#62331)
it uses the same context as a Host Tx buffer
allocator for gatt sending. Host cannot wait for
free buffer anymore. Mesh requires 4 buffers
to send max size frame(public key) during
provisioning.

Signed-off-by: Aleksandr Khromykh <[email protected]>
HaavardRei pushed a commit to HaavardRei/sdk-zephyr that referenced this pull request Jan 12, 2024
@alxelax @HaavardRei
[nrf fromtree] Bluetooth: Mesh: allocate mesh max required buffer number
f4d537c 
Since sending of public key was moved into system
work (zephyrproject-rtos/zephyr#62331)
it uses the same context as a Host Tx buffer
allocator for gatt sending. Host cannot wait for
free buffer anymore. Mesh requires 4 buffers
to send max size frame(public key) during
provisioning.

Signed-off-by: Aleksandr Khromykh <[email protected]>
(cherry picked from commit 3d37549)
Signed-off-by: Håvard Reierstad <[email protected]>
rlubos pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Jan 15, 2024
@alxelax @rlubos
[nrf fromtree] Bluetooth: Mesh: allocate mesh max required buffer number
accb038 
Since sending of public key was moved into system
work (zephyrproject-rtos/zephyr#62331)
it uses the same context as a Host Tx buffer
allocator for gatt sending. Host cannot wait for
free buffer anymore. Mesh requires 4 buffers
to send max size frame(public key) during
provisioning.

Signed-off-by: Aleksandr Khromykh <[email protected]>
(cherry picked from commit 3d37549)
Signed-off-by: Håvard Reierstad <[email protected]>
jfischer-no pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Mar 8, 2024
@alxelax @jfischer-no
[nrf fromtree] Bluetooth: Mesh: allocate mesh max required buffer number
e1fe018 
Since sending of public key was moved into system
work (zephyrproject-rtos/zephyr#62331)
it uses the same context as a Host Tx buffer
allocator for gatt sending. Host cannot wait for
free buffer anymore. Mesh requires 4 buffers
to send max size frame(public key) during
provisioning.

Signed-off-by: Aleksandr Khromykh <[email protected]>
(cherry picked from commit 3d37549)
Signed-off-by: Håvard Reierstad <[email protected]>
(cherry picked from commit accb038)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxelax alxelax alxelax approved these changes

@PavelVPV PavelVPV PavelVPV approved these changes

@akredalen akredalen Awaiting requested review from akredalen

@Andrewpini Andrewpini Awaiting requested review from Andrewpini

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@asbjornsabo asbjornsabo Awaiting requested review from asbjornsabo

@hermabe hermabe Awaiting requested review from hermabe

@jori-nordic jori-nordic Awaiting requested review from jori-nordic

@kruithofa kruithofa Awaiting requested review from kruithofa

@sjanc sjanc Awaiting requested review from sjanc

@Thalley Thalley Awaiting requested review from Thalley

@Vudentz Vudentz Awaiting requested review from Vudentz

@dcpleung dcpleung Awaiting requested review from dcpleung

@nashif nashif Awaiting requested review from nashif

@andyross andyross Awaiting requested review from andyross

@tejlmand tejlmand Awaiting requested review from tejlmand

@jhedberg jhedberg Awaiting requested review from jhedberg

Assignees

@PavelVPV PavelVPV

Labels
area: Bluetooth Host area: Bluetooth Mesh area: Bluetooth area: Build System
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
6 participants
@LingaoM @alxelax @PavelVPV @fabiobaltieri @carlescufi @zephyrbot