ev11l78a: add en_sink as a custom binding. #61740

Flameeyes · 2023-08-22T12:52:50Z

ev11l78a: add en_sink as a custom binding.

This exposes the EN_SINK signal as a custom binding, since it is ore to
the business logic of the board.

EN_SINK is a GPIO line connected to a MOSFET that provides power on the
screw terminal of the board, and should be enabled after USB-PD
negotiation.

Signed-off-by: Diego Elio Pettenò [email protected]

Stack created with Sapling. Best reviewed with ReviewStack.

gmarull · 2023-08-22T13:10:54Z

boards/arm/ev11l78a/ev11l78a.dts

+
+		// The following are not LEDs on the board, but rather
+		// testpoints. On the other hand, they are "fit the part."
+		ind_1_5a: led_1 {
+			gpios = <&porta 1 GPIO_ACTIVE_HIGH>;
+			label = "1.5A_IND";
+		};
+
+		ind_3_0a: led_2 {
+			gpios = <&porta 15 GPIO_ACTIVE_HIGH>;
+			label = "3.0A_IND";
+		};
 	};


if not LEDs, why under gpio-leds?

It seemed the easiest way to expose these with an actual label — but I'm not convinced myself. What other options are there?

likely https://github.com/zephyrproject-rtos/zephyr/tree/main/samples/basic/custom_dts_binding, but if not used upstream, you should likely keep these downstream.

gmarull · 2023-08-22T13:11:10Z

boards/arm/ev11l78a/ev11l78a.dts

+	enable_sink: enable_sink {
+		compatible = "microchip,ev11l78a-ensink";
+		gpios = <&porta 22 GPIO_ACTIVE_HIGH>;
+	};


looks like a regulator-fixed?

Almost but not quite? It's technically not fixed, because it's controlled by the TCPC, but as far as I can tell there's no precedent for a TCPC controlled regulator.

But I guess it would work by not passing min/max microvolt, hmm.

so if controlled by TCPC it should be a property there, something like:

tcpc { enable-sink-gpios = <...>; };

then TCPC code would use the GPIO API. Or, if using regulators:

enable_sink: enable-sink { compatible = "regulator-fixed"; enable-gpios = <...>; }; ... tcpc { ... sink-supply = <&enable_sink>; };

Then TCPC would use the regulators API (main advantage is that it is reference counted, useful if supply is shared).

So this is a bit more complicated — the voltage is controlled by a TCPC (for which I'm writing the driver, slowly), but the output of the board is controlled by a MOSFET controlled by this GPIO.

So maybe a fixed regulator would be the best fit? While the indicators could be ignored (although I really would have preferred labeling them, they are part of the board after all, even if they're just test points) I believe this GPIO needs to be exposed as it is clearly part of the eval part of the board.

It depends on how it is used, if by multiple clients then regulator is a good fit, is by a single client, a GPIO does the job. A typical case for GPIO usage is e.g. on sensors that have a shutdown pin. I don't know this case in detail to suggest one way or the other.

To be honest, this is almost the literal case from the documentation you linked earlier as it's a GPIO connected to a specific MOSFET…

Leaving it as a generic GPIO doesn't seem right though — it's most certainly no longer "General-purpose" once it's wired to the MOSFET on the board, and it has a very specific function.

Flameeyes

Let me move the important change (memory and flash size) to #61744 that is more generic, and I'll follow up here about the regulator/sink enable option.

Flameeyes · 2023-08-22T13:22:35Z

boards/arm/ev11l78a/ev11l78a.dts

+
+		// The following are not LEDs on the board, but rather
+		// testpoints. On the other hand, they are "fit the part."
+		ind_1_5a: led_1 {
+			gpios = <&porta 1 GPIO_ACTIVE_HIGH>;
+			label = "1.5A_IND";
+		};
+
+		ind_3_0a: led_2 {
+			gpios = <&porta 15 GPIO_ACTIVE_HIGH>;
+			label = "3.0A_IND";
+		};
 	};


It seemed the easiest way to expose these with an actual label — but I'm not convinced myself. What other options are there?

Flameeyes · 2023-08-22T13:28:09Z

boards/arm/ev11l78a/ev11l78a.dts

+	enable_sink: enable_sink {
+		compatible = "microchip,ev11l78a-ensink";
+		gpios = <&porta 22 GPIO_ACTIVE_HIGH>;
+	};


Almost but not quite? It's technically not fixed, because it's controlled by the TCPC, but as far as I can tell there's no precedent for a TCPC controlled regulator.

But I guess it would work by not passing min/max microvolt, hmm.

nandojve · 2023-10-18T10:43:28Z

You need rebase : )

nandojve · 2023-11-26T09:24:30Z

Ping

The ATSAMD20E16 used in this board only has 8KiB SRAM, so the defaults are not really suitable for anything close to useful, particularly the sink sample that most closely resembles the original demo for the board. This should also allow more tests not to be skipped for this board as otherwise they overflow RAM usage. Signed-off-by: Diego Elio Pettenò <[email protected]>

This configures the DAC in the same way as it is configured for the arduino_zero and other similar boards. It also includes the board in the DAC tests. Signed-off-by: Diego Elio Pettenò <[email protected]>

This exposes the EN_SINK signal as a custom binding, since it is ore to the business logic of the board. EN_SINK is a GPIO line connected to a MOSFET that provides power on the screw terminal of the board, and should be enabled after USB-PD negotiation. Signed-off-by: Diego Elio Pettenò <[email protected]>

nandojve · 2024-01-09T16:52:30Z

Hi @Flameeyes ,

Is there anything pending from your side on this?

github-actions · 2024-03-10T00:29:49Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

Flameeyes requested review from nashif, MaureenHelm and galak as code owners August 22, 2023 12:52

gmarull requested changes Aug 22, 2023

View reviewed changes

Flameeyes commented Aug 22, 2023

View reviewed changes

Flameeyes mentioned this pull request Aug 22, 2023

samx2x: separate RAM/Flash sizes by model. #61744

Merged

Flameeyes force-pushed the pr61740 branch from 4418970 to 6f91b9c Compare August 22, 2023 13:39

Flameeyes requested a review from soburi as a code owner August 22, 2023 13:39

zephyrbot added platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) area: DAC Digital-to-Analog Converter labels Aug 22, 2023

zephyrbot requested review from attie-argentum, martinjaeger, mnkp, nandojve, pdgendt and stephanosio August 22, 2023 13:40

zephyrbot assigned nandojve Aug 22, 2023

Flameeyes force-pushed the pr61740 branch from 6f91b9c to a622e1e Compare August 22, 2023 13:55

Flameeyes mentioned this pull request Sep 10, 2023

ev11l78a: minimize memory usage in the default config. #61797

Merged

Flameeyes force-pushed the pr61740 branch 2 times, most recently from beb5bcf to 1c92c40 Compare September 10, 2023 11:18

Flameeyes changed the title ~~ev11l78a: update devicetree definition of ev11l78a.~~ ev11l78a: add en_sink as a custom binding. Sep 10, 2023

Flameeyes force-pushed the pr61740 branch from 1c92c40 to 181f087 Compare September 10, 2023 18:54

Flameeyes mentioned this pull request Sep 10, 2023

ev11l78a: configure DAC peripheral #62478

Closed

Flameeyes added 3 commits November 26, 2023 20:06

ev11l78a: configure DAC peripheral

9bcfe68

This configures the DAC in the same way as it is configured for the arduino_zero and other similar boards. It also includes the board in the DAC tests. Signed-off-by: Diego Elio Pettenò <[email protected]>

Flameeyes force-pushed the pr61740 branch from 181f087 to 8e3c219 Compare November 26, 2023 20:19

github-actions bot added the Stale label Mar 10, 2024

github-actions bot closed this Mar 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ev11l78a: add en_sink as a custom binding. #61740

ev11l78a: add en_sink as a custom binding. #61740

Flameeyes commented Aug 22, 2023 •

edited

Loading

gmarull Aug 22, 2023

Flameeyes Aug 22, 2023

gmarull Aug 23, 2023

gmarull Aug 22, 2023

Flameeyes Aug 22, 2023

gmarull Aug 23, 2023 •

edited

Loading

Flameeyes Aug 23, 2023

gmarull Aug 23, 2023

Flameeyes Aug 24, 2023

Flameeyes left a comment

Flameeyes Aug 22, 2023

Flameeyes Aug 22, 2023

nandojve commented Oct 18, 2023

nandojve commented Nov 26, 2023

nandojve commented Jan 9, 2024

github-actions bot commented Mar 10, 2024

ev11l78a: add en_sink as a custom binding. #61740

ev11l78a: add en_sink as a custom binding. #61740

Conversation

Flameeyes commented Aug 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gmarull Aug 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Flameeyes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nandojve commented Oct 18, 2023

nandojve commented Nov 26, 2023

nandojve commented Jan 9, 2024

github-actions bot commented Mar 10, 2024

Flameeyes commented Aug 22, 2023 •

edited

Loading

gmarull Aug 23, 2023 •

edited

Loading