Bluetooth: controller: LLCP: Fix encryption execution context #60823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoh-ot
changed the title
thoh-ot
force-pushed
the
fix_llcp_encrypt_exec_context
branch
from
f59c85e
to
789e22a
Compare
thoh-ot
requested review from
cvinayak,
kruithofa,
erbr-ot,
sjanc and
carlescufi
as code owners
kruithofa
previously approved these changes
Jul 31, 2023
rp_enc_state_wait_ltk_reply() is executed in thread context, so it is not allowed to move the encryption state machine forward. Defer LTK reply handling to next prepare event by introducing a continue state. Update the unit test to reflect this, and remove the TODO that actually said there was an issue in the first place. Signed-off-by: Thomas Ebert Hansen <[email protected]>
thoh-ot
force-pushed
the
fix_llcp_encrypt_exec_context
branch
from
789e22a
to
c43d2f7
Compare
|
Rebased |
kruithofa
approved these changes
Aug 29, 2023
cvinayak
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rp_enc_state_wait_ltk_reply() is executed in thread context, so it is not allowed to move the encryption state machine forward.
Defer LTK reply handling to next prepare event by introducing a continue state.
Update the unit test to reflect this, and remove the TODO that actually said there was an issue in the first place.