Add implementation for Public Broadcast Profile and dedicated sample apps #60777

andreeaDumitrache · 2023-07-25T11:01:28Z

PBP API allows sources to create a Public Broadcast Announcement.
PBP API to parse a Public Broadcast Announcement.

public_broadcast_source application starts extended advertising and
includes a Public Broadcast Announcement. The advertised broadcast
audio stream quality will cycle between high and standard quality.

public_broadcast_sink application scans for broadcast sources and
synchronizes to the first found source which defines a Public Broadcast
Announcement including a High Quality Public Broadcast Audio Stream
configuration.

Add bsim tests for Public Broadcast Profile APIs.

Add shell implementation for Public Broadcast Profile APIs.

fixes #41226

github-actions

Hello @andreeaDumitrache, and thank you very much for your first pull request to the Zephyr project!

A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊

aescolar

@andreeaDumitrache

tests/bsim/bluetooth/audio/test_scripts/pbp.sh

Remember to give execute permissions to that new script

include/zephyr/bluetooth/audio/pbp.h

kartben · 2023-07-26T00:56:17Z

include/zephyr/bluetooth/audio/pbp.h

+enum bt_pbp_encryption {
+	BT_PBP_STREAMS_NOT_ENCRYPTED = 0,
+	BT_PBP_STREAMS_ENCRYPTED = 1,
+};
+
+enum bt_pbp_quality {
+	BT_PBP_AUDIO_CONFIG_NOT_PRESENT = 0,
+	BT_PBP_AUDIO_CONFIG_PRESENT = 1,
+};
+
+enum bt_pbp_announcement_features {
+	BT_PBP_ANNOUNCEMENT_FEATURE_ENCRYPTION = BIT(0),
+	BT_PBP_ANNOUNCEMENT_FEATURE_STANDARD_QUALITY = BIT(1),
+	BT_PBP_ANNOUNCEMENT_FEATURE_HIGH_QUALITY = BIT(2),
+};


Missing Doxygen comments?

include/zephyr/bluetooth/audio/pbp.h

subsys/bluetooth/audio/pbp.c

include/zephyr/bluetooth/audio/pbp.h

samples/bluetooth/public_broadcast_sink/src/bap_broadcast_sink.c

samples/bluetooth/public_broadcast_source/src/cap_initiator.c

subsys/bluetooth/audio/pbp.c

Thalley

I've only reviewed the public header file so far.

I don't think the functions supplied in that file really warrant a pbp.c implementation, as the functions do not really implement any requirements from the PBP spec, but do require significant amount of memory for very simple things that probably are best left up to the application.

Let's discuss and resolve my comments before I start reviewing the samples, tests and implementation

include/zephyr/bluetooth/audio/pbp.h

Thalley

Looks pretty good now. Some final comments regarding the passing and generation of the PBA

subsys/bluetooth/audio/pbp.c

include/zephyr/bluetooth/audio/pbp.h

subsys/bluetooth/audio/Kconfig.pbp

subsys/bluetooth/audio/pbp.c

subsys/bluetooth/audio/shell/pbp.c

Thalley

A few minor comments to the header file, otherwise LGTM

include/zephyr/bluetooth/audio/pbp.h

samples/bluetooth/public_broadcast_sink/sysbuild.cmake

samples/bluetooth/public_broadcast_source/sample.yaml

samples/bluetooth/public_broadcast_source/sysbuild.cmake

PBP API allows sources to create a Public Broadcast Announcement. PBP API to parse a Public Broadcast Announcement. public_broadcast_source application starts extended advertising and includes a Public Broadcast Announcement. The advertised broadcast audio stream quality will cycle between high and standard quality. public_broadcast_sink application scans for broadcast sources and synchronizes to the first found source which defines a Public Broadcast Announcement including a High Quality Public Broadcast Audio Stream configuration. Add bsim tests for Public Broadcast Profile APIs. Add shell implementation for Public Broadcast Profile APIs. Signed-off-by: Daniela Andreea Dumitrache <[email protected]>

Thalley · 2023-12-19T07:35:42Z

@kartben Will you approve or remove your change request so we can get this merged please?

Thalley · 2024-01-09T07:25:18Z

@kartben please re-review or dismiss your review :)

kartben

Nice to see Bluetooth samples using zephyr:code-sample sphinx directive!

kartben · 2024-01-09T07:37:02Z

@kartben please re-review or dismiss your review :)

Missed this before the holidays, sorry

github-actions · 2024-01-09T08:59:59Z

Hi @andreeaDumitrache!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

andreeaDumitrache requested review from nashif, jhedberg, Vudentz, wopu-ot, Thalley, sjanc and alwa-nordic as code owners July 25, 2023 11:01

zephyrbot added area: Bluetooth area: Bluetooth Audio labels Jul 25, 2023

zephyrbot requested review from asbjornsabo, Casper-Bonde-Bose, fredrikdanebjer, hermabe, kruithofa, larsgk, MariuszSkamra and szymon-czapracki July 25, 2023 11:02

zephyrbot assigned jhedberg Jul 25, 2023

github-actions bot reviewed Jul 25, 2023

View reviewed changes

andreeaDumitrache force-pushed the add_public_broadcast_profile branch from 4cc7de3 to 265b80e Compare July 25, 2023 11:24

aescolar reviewed Jul 25, 2023

View reviewed changes

andreeaDumitrache force-pushed the add_public_broadcast_profile branch from 265b80e to 0c72825 Compare July 25, 2023 15:12

kartben requested review from kartben and removed request for szymon-czapracki July 26, 2023 00:47

kartben requested changes Jul 26, 2023

View reviewed changes

andreeaDumitrache force-pushed the add_public_broadcast_profile branch 3 times, most recently from d93b9ff to 036ceac Compare July 27, 2023 14:12

MariuszSkamra requested changes Aug 9, 2023

View reviewed changes

Thalley requested changes Aug 14, 2023

View reviewed changes

andreeaDumitrache force-pushed the add_public_broadcast_profile branch 3 times, most recently from 3372312 to 0417393 Compare December 5, 2023 12:03

Thalley requested changes Dec 5, 2023

View reviewed changes

subsys/bluetooth/audio/pbp.c Outdated Show resolved Hide resolved

subsys/bluetooth/audio/pbp.c Outdated Show resolved Hide resolved

subsys/bluetooth/audio/pbp.c Outdated Show resolved Hide resolved

MariuszSkamra requested changes Dec 5, 2023

View reviewed changes

include/zephyr/bluetooth/audio/pbp.h Outdated Show resolved Hide resolved

andreeaDumitrache force-pushed the add_public_broadcast_profile branch from 0417393 to 12f6104 Compare December 6, 2023 11:44

Thalley requested changes Dec 6, 2023

View reviewed changes

subsys/bluetooth/audio/Kconfig.pbp Outdated Show resolved Hide resolved

subsys/bluetooth/audio/pbp.c Outdated Show resolved Hide resolved

subsys/bluetooth/audio/shell/pbp.c Outdated Show resolved Hide resolved

subsys/bluetooth/audio/shell/pbp.c Outdated Show resolved Hide resolved

andreeaDumitrache changed the title ~~Add implementation for Public Broadcast Profile and update TMAP broadcast sample apps~~ Add implementation for Public Broadcast Profile and dedicated sample apps Dec 6, 2023

andreeaDumitrache force-pushed the add_public_broadcast_profile branch 5 times, most recently from 9bc7642 to cbec895 Compare December 13, 2023 13:17

Thalley requested changes Dec 15, 2023

View reviewed changes

include/zephyr/bluetooth/audio/pbp.h Outdated Show resolved Hide resolved

include/zephyr/bluetooth/audio/pbp.h Outdated Show resolved Hide resolved

include/zephyr/bluetooth/audio/pbp.h Outdated Show resolved Hide resolved

include/zephyr/bluetooth/audio/pbp.h Outdated Show resolved Hide resolved

Thalley requested review from kartben, aescolar, MariuszSkamra and Thalley December 15, 2023 12:48

andreeaDumitrache force-pushed the add_public_broadcast_profile branch from cbec895 to a6f71a4 Compare December 15, 2023 14:00

aescolar reviewed Dec 15, 2023

View reviewed changes

samples/bluetooth/public_broadcast_sink/sysbuild.cmake Outdated Show resolved Hide resolved

samples/bluetooth/public_broadcast_source/sample.yaml Show resolved Hide resolved

samples/bluetooth/public_broadcast_source/sysbuild.cmake Outdated Show resolved Hide resolved

andreeaDumitrache force-pushed the add_public_broadcast_profile branch from a6f71a4 to c335578 Compare December 15, 2023 14:46

Thalley approved these changes Dec 15, 2023

View reviewed changes

MariuszSkamra approved these changes Dec 18, 2023

View reviewed changes

kartben approved these changes Jan 9, 2024

View reviewed changes

carlescufi merged commit 3bfb2e3 into zephyrproject-rtos:main Jan 9, 2024
21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add implementation for Public Broadcast Profile and dedicated sample apps #60777

Add implementation for Public Broadcast Profile and dedicated sample apps #60777

andreeaDumitrache commented Jul 25, 2023 •

edited

Loading

github-actions bot left a comment

aescolar left a comment

kartben Jul 26, 2023

Thalley left a comment

Thalley left a comment

Thalley left a comment

Thalley commented Dec 19, 2023

Thalley commented Jan 9, 2024

kartben left a comment

kartben commented Jan 9, 2024

github-actions bot commented Jan 9, 2024

Add implementation for Public Broadcast Profile and dedicated sample apps #60777

Add implementation for Public Broadcast Profile and dedicated sample apps #60777

Conversation

andreeaDumitrache commented Jul 25, 2023 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

aescolar left a comment

Choose a reason for hiding this comment

kartben Jul 26, 2023

Choose a reason for hiding this comment

Thalley left a comment

Choose a reason for hiding this comment

Thalley left a comment

Choose a reason for hiding this comment

Thalley left a comment

Choose a reason for hiding this comment

Thalley commented Dec 19, 2023

Thalley commented Jan 9, 2024

kartben left a comment

Choose a reason for hiding this comment

kartben commented Jan 9, 2024

github-actions bot commented Jan 9, 2024

andreeaDumitrache commented Jul 25, 2023 •

edited

Loading