Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renesas: Smartbond: Add Crypto Driver Support #60238

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Renesas: Smartbond: Add Crypto Driver Support #60238

merged 3 commits into from
Oct 26, 2023

Conversation

ioannis-karachalios
Copy link
Contributor

No description provided.

@zephyrbot zephyrbot added platform: Renesas SmartBond Renesas Electronics Corporation, SmartBond area: Crypto / RNG labels Jul 11, 2023
@zephyrbot zephyrbot added manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) labels Jul 11, 2023
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jul 11, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_renesas zephyrproject-rtos/hal_renesas@a6cf2af zephyrproject-rtos/hal_renesas@1471ed3 (main) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nordicjm
nordicjm requested changes Jul 11, 2023
View reviewed changes
drivers/crypto/Kconfig.smartbond Show resolved Hide resolved
drivers/crypto/Kconfig.smartbond Outdated Show resolved Hide resolved
@carlescufi carlescufi changed the title Add Crypto Driver Support Renesas: Smartbond: Add Crypto Driver Support Jul 11, 2023
nordicjm
nordicjm previously requested changes Jul 11, 2023
View reviewed changes
drivers/crypto/Kconfig.smartbond Outdated Show resolved Hide resolved
drivers/crypto/Kconfig.smartbond Outdated Show resolved Hide resolved
drivers/crypto/Kconfig.smartbond Show resolved Hide resolved
@nordicjm nordicjm dismissed their stale review July 11, 2023 10:07

Issues addressed

@zephyrbot zephyrbot added the area: Devicetree Binding PR modifies or adds a Device Tree binding label Jul 11, 2023
@ioannis-karachalios ioannis-karachalios force-pushed the da1469x-crypto branch 7 times, most recently from 02f94b5 to c325139 Compare July 24, 2023 14:01
@ioannis-karachalios ioannis-karachalios force-pushed the da1469x-crypto branch 3 times, most recently from a99a8b3 to ad40f80 Compare October 9, 2023 08:27
@ioannis-karachalios
Copy link
Contributor Author

Hi all, I re-ordered commits history so bisection is not broken and pushed some minor updates mainly concerning style changes. I ran the crypto (hash) test suite and here is a screenshot of my console:
crypto_hash Console Output (all tasks passed)
crypto_hash_test_suite_console
I also ran the crypto driver sample, successfully (all tasks passed except CCM and GCM which are not natively supported)
samples_driver_crypto_console

@andrzej-kaczmarek
Copy link
Collaborator

@ioannis-karachalios please update west.yml with proper sha for hal_renesas

@zephyrbot zephyrbot added the area: RTC Real Time Clock label Oct 24, 2023
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Oct 24, 2023
@ioannis-karachalios ioannis-karachalios force-pushed the da1469x-crypto branch 2 times, most recently from 5dc118f to 640e9a9 Compare October 24, 2023 08:57
@ioannis-karachalios
west.yml: Update hal_renesas revision
9d9c31d 
Adds new HAL to be used by existing and upcoming drivers.

Signed-off-by: Ioannis Karachalios <[email protected]>
@ioannis-karachalios
drivers: crypto: smartbond: Support crypto accelerator
61f40ac 
Add support for the crypto engine.

Signed-off-by: Ioannis Karachalios <[email protected]>
@ioannis-karachalios
dts: renesas: smartbond: Support crypto peripheral
7467106 
Update DTS and board configurations to support the crypto engine.

Signed-off-by: Ioannis Karachalios <[email protected]>
@ioannis-karachalios
Copy link
Contributor Author

ioannis-karachalios commented Oct 24, 2023 •
edited
Loading

@ioannis-karachalios please update west.yml with proper sha for hal_renesas

@andrzej-kaczmarek west.yml has been updated and conflicts were resolved. During rebasing, I added, by mistake, some files not relevant to this PR and the RTC tag was added automatically. It's now fixed but the tag is still there.

@andrzej-kaczmarek andrzej-kaczmarek removed the area: RTC Real Time Clock label Oct 24, 2023
@jukkar jukkar removed area: Networking area: Sockets Networking sockets labels Oct 25, 2023
bjarki-andreasen
bjarki-andreasen approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlescufi carlescufi merged commit 112c395 into zephyrproject-rtos:main Oct 26, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrzej-kaczmarek andrzej-kaczmarek andrzej-kaczmarek approved these changes

@bjarki-andreasen bjarki-andreasen bjarki-andreasen approved these changes

@aaillet aaillet Awaiting requested review from aaillet

@pmarzin pmarzin Awaiting requested review from pmarzin

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@galak galak Awaiting requested review from galak

@ceolin ceolin Awaiting requested review from ceolin

@nordicjm nordicjm Awaiting requested review from nordicjm

@nashif nashif Awaiting requested review from nashif

Assignees

@andrzej-kaczmarek andrzej-kaczmarek

Labels
area: Crypto / RNG area: Devicetree Binding PR modifies or adds a Device Tree binding manifest manifest-hal_renesas platform: Renesas SmartBond Renesas Electronics Corporation, SmartBond
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ioannis-karachalios @zephyrbot @andrzej-kaczmarek @nordicjm @bjarki-andreasen @jukkar @carlescufi