tests: kernel/smp: mark torture test as skipped if factor is 0 #59831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If CONFIG_SMP_TEST_RUN_FACTOR is zero, the switch torture test is effectively not doing anything as the k_sleep() below is not going to sleep at all, and all created threads are being terminated (almost) immediately after creation. So if run factor is zero, mark the test as skipped. Signed-off-by: Daniel Leung <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
peter-mitsis
approved these changes
Jun 28, 2023
ceolin
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If CONFIG_SMP_TEST_RUN_FACTOR is zero, the switch torture test is effectively not doing anything as the k_sleep() below is not going to sleep at all, and all created threads are being terminated (almost) immediately after creation. So if run factor is zero, mark the test as skipped.