tests: kernel/sys_mutex: sleep a bit for private_mutex to lock #59830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
405
to
406
| k_sleep(K_MSEC(1)); /* Give thread_12 a chance to lock */ | ||
|
|
There was a problem hiding this comment.
I may be missing something, but I am not seeing why this is needed on SMP. The ownership/lock should automatically be assigned to thread_12 before that 2nd sys_mutex_unlock() returns. If there is a race in SMP, then I would have expected it to be due to the pre-existing k_sleep(K_MSEC(1)) on line 400 being too short a time to get thread_12 into the mutex's wait queue.
There was a problem hiding this comment.
Good point. I have make the sleep on line 400 longer instead.
dcpleung
force-pushed
the
tests/kernel/sys_mutex_private_mutex_delay_lock
branch
from
b8941b9
to
1904bd5
Compare
With SMP, the private_mutex may not be locked fast enough by thread_12 after the thread creation as it might take longer for a thread to start running the entry function, resulting in test failure when the main test thread goes into locking it again. So give it a bit more delay after thread creation so thread_12 has a chance to lock the private_mutex. Signed-off-by: Daniel Leung <[email protected]>
peter-mitsis
approved these changes
Jun 28, 2023
nashif
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With SMP, the private_mutex may not be locked fast enough by thread_12 after the thread creation as it might take longer for a thread to start running the entry function, resulting in test failure when the main test thread goes into locking it again. So give it a bit more delay after thread creation so thread_12 has a chance to lock the private_mutex.