Bluetooth: Mesh: instantiate cdb and core keys #59816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxelax
requested review from
jhedberg,
PavelVPV,
Vudentz and
LingaoM
as code owners
alxelax
force-pushed
the
optomize_cdb_psa
branch
from
ec2a013
to
f314681
Compare
PavelVPV
reviewed
Jun 29, 2023
alxelax
force-pushed
the
optomize_cdb_psa
branch
from
f314681
to
edfa3ed
Compare
PavelVPV
previously approved these changes
Jun 29, 2023
|
Minor nitpick: there is a typo in the commit message "APIand" where I belive there is missing a space char. No big deal, up to you if you want to fix it. |
Andrewpini
reviewed
Jul 3, 2023
subsys/bluetooth/mesh/main.c
Outdated
| @@ -101,16 +102,15 @@ int bt_mesh_provision(const uint8_t net_key[16], uint16_t net_idx, | |||
| subnet->kr_phase = BT_MESH_KR_NORMAL; | |||
| } | |||
|
|
|||
| /* The network key has already been existed. Importing leaves it 'as is' | |||
There was a problem hiding this comment.
Suggested change
| /* The network key has already been existed. Importing leaves it 'as is' | |
| /* The network key has already been exported. Importing leaves it 'as is' |
?
There was a problem hiding this comment.
It wasn't exported. The primary network key is imported during cdb creation. Never mind, I'll clarify it.
subsys/bluetooth/mesh/main.c
Outdated
Comment on lines
106
to
108
| * if key is the same. Otherwise, cdb replaces the old one by the new one. | ||
| */ |
There was a problem hiding this comment.
Suggested change
| * if key is the same. Otherwise, cdb replaces the old one by the new one. | |
| */ | |
| * if the key is the same. Otherwise, cdb replaces the old one with the new one. | |
| */ |
PR instantiates cdb and core keys to prevent scenario when key is changed over cdb API and gets new ID but core still operates with old ID(potentially invalid). Known issue the keys will be desynchronized during\after key refresh procedure. Signed-off-by: Aleksandr Khromykh <[email protected]>
Andrewpini
approved these changes
Jul 4, 2023
PavelVPV
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR instantiates cdb and core keys to prevent scenario when key is changed over cdb APIand gets new ID but core still operates with old ID(potentially invalid).
Known issue the keys will be desynchronized during\after key refresh procedure.