[Backport v3.4-branch] Fix linker scripts to define _end correctly #59808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…M data The Zephyr linker scripts have inconsistent ordering of various chunks of data which lands in RAM at runtime. This leads to the value of _end not being consistently defined as the maximum address of static variables used in the application. Create a helper linker fragment, zephyr/linker/ram-end.ld, which can be included after the last possible definition of RAM data, that consistently sets _image_ram_end, _end and z_mapped_end. Signed-off-by: Keith Packard <[email protected]> (cherry picked from commit 710422e)
The generated scripts don't include a definition for any symbol indicating the end of statically allocated memory (such as "_end"). Add a shared cmake fragment, ram-end.cmake, which contains the necessary instructions to define _end and z_mapped_end consistently to align with the other sample linker scripts. Signed-off-by: Keith Packard <[email protected]> (cherry picked from commit bbec614)
zephyrbot
requested review from
nashif,
andyross,
julius-barendt,
jhedberg,
kgugala,
pgielda,
carlocaione,
stephanosio,
MaureenHelm,
galak,
ioannisg,
abrodkin,
ruuddw,
evgeniy-paltsev,
tejlmand,
aasthagr and
dleach02
as code owners
tejlmand
approved these changes
Jul 5, 2023
|
@keith-packard can you add a tracking issue for this? |
Like this: #60545 ? |
Cool, thanks! |
|
Can some more people take a look at this one? |
fabiobaltieri
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport bbec614~2..bbec614 from #57727.
Fixes: #60545