Bluetooth: Controller: Add LL_ASSERT_OVERHEAD define #59801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add -ECANCELED on return from lll_preempt_calc so that assert check can be placed in the prepare callbacks of the state/role implementations. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_ll_assert_overhead
branch
from
a02bb86
to
f73bc87
Compare
cvinayak
force-pushed
the
github_ll_assert_overhead
branch
from
f73bc87
to
a6b6862
Compare
cvinayak
force-pushed
the
github_ll_assert_overhead
branch
from
a6b6862
to
d5234fa
Compare
Thalley
requested changes
Jun 29, 2023
Comment on lines
+416
to
+423
| /* FIXME: When Flush Timeout is implemented */ | ||
| if (cis_lll->tx.bn_curr <= cis_lll->tx.bn) { | ||
| lll_flush_tx(cis_lll); | ||
| } | ||
|
|
||
| /* Adjust nesn when flushing Rx */ | ||
| /* FIXME: When Flush Timeout is implemented */ |
There was a problem hiding this comment.
These two FIXME does not contain enough/any information for anyone else to know how to fix.
There was a problem hiding this comment.
The fix is quite complicated, and best left to have this "When Flush Timeout is implemented" and is replaced in the implemention in this commit: e92d72d
There was a problem hiding this comment.
I guess that's OK. Generally it would be nice if they could refer to an existing PR or GH Issue so that someone looking at the code don't end up scratching their heads too much :D
Move the EVENT_OVERHEAD_START_US verbose assertion to each state/role LLL implementation so that correct state/role that is delayed is conveyed in the assertion message. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix Connected ISO implementation to correctly handle SN, NESN and payload_count when prepare callback is aborted due to CPU overhead related latencies. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Add LL_ASSERT_OVERHEAD define to reuse the assertion check related to increase in actual EVENT_OVERHEAD_START_US value. Introduce Kconfig option to permit radio event be skipped when increased prepare callback latencies are measured, instead of assertion. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
cvinayak
force-pushed
the
github_ll_assert_overhead
branch
from
d5234fa
to
268c1c9
Compare
Thalley
approved these changes
Jun 29, 2023
Comment on lines
+416
to
+423
| /* FIXME: When Flush Timeout is implemented */ | ||
| if (cis_lll->tx.bn_curr <= cis_lll->tx.bn) { | ||
| lll_flush_tx(cis_lll); | ||
| } | ||
|
|
||
| /* Adjust nesn when flushing Rx */ | ||
| /* FIXME: When Flush Timeout is implemented */ |
There was a problem hiding this comment.
I guess that's OK. Generally it would be nice if they could refer to an existing PR or GH Issue so that someone looking at the code don't end up scratching their heads too much :D
kruithofa
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LL_ASSERT_OVERHEAD define to reuse the assertion check
related to increase in actual EVENT_OVERHEAD_START_US value.
Introduce Kconfig option to permit radio event be skipped
when increased prepare callback latencies are measured,
instead of assertion.
Signed-off-by: Vinayak Kariappa Chettimada [email protected]