Host Command improvements #59781
Merged
Host Command improvements #59781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niedzwiecki-dawid
requested review from
nashif,
carlescufi,
galak and
MaureenHelm
as code owners
niedzwiecki-dawid
force-pushed
the
hc_imp
branch
from
50c7b2c
to
196644a
Compare
fabiobaltieri
previously approved these changes
Jul 3, 2023
keith-zephyr
reviewed
Jul 6, 2023
Add a config to save the final result of a last host command that has sent EC_HOST_CMD_IN_PROGRESS response. To get the final result use the ec_host_cmd_send_in_progress_status function. Signed-off-by: Dawid Niedzwiecki <[email protected]>
Add a function to signal a new host command by a backend. Use a function instead of giving semaphore, because it allows more actions on rx event, common for all backends. Signed-off-by: Dawid Niedzwiecki <[email protected]>
Verify validity of a received command before passing it to the general handler. It allows performing some actions, right after receiving the command. The context switch is not needed. Such feature may be needed for overloaded system, where instant reboot is required. Signed-off-by: Dawid Niedzwiecki <[email protected]>
Add a user possibility to set a callback for receiving a new function. It allows instant performing some actions, that need to be done before context switch. Signed-off-by: Dawid Niedzwiecki <[email protected]>
fabiobaltieri
approved these changes
Jul 7, 2023
keith-zephyr
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements of Host Command subsystem:
-handling IN_PROGRESS status
-common function for signaling a new function
-user callback