soc: xtensa: esp32s3: add support for SPIRAM #59770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uLipe
previously approved these changes
Jun 26, 2023
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
sylvioalves
previously approved these changes
Jul 3, 2023
marekmatej
reviewed
Jul 5, 2023
| @@ -18,3 +18,6 @@ config HEAP_MEM_POOL_SIZE | |||
| choice BT_HCI_BUS_TYPE | |||
| default BT_ESP32 if BT | |||
| endchoice | |||
|
|
|||
| config ESP_SPIRAM | |||
| default y | |||
There was a problem hiding this comment.
I think SPIRAM should be enabled in the application code rather on board level.
There was a problem hiding this comment.
Would be great if if would be selected automatically based on devicetree node corresponding to SPIRAM.
|
Could we please wait until #58454 gets merged? |
mniestroj
reviewed
Jul 5, 2023
marekmatej
previously approved these changes
Jul 6, 2023
LucasTambor
force-pushed
the
feature/s3_spiram
branch
2 times, most recently
from
d007997
to
d54676b
Compare
marekmatej
reviewed
Jul 25, 2023
marekmatej
reviewed
Jul 25, 2023
marekmatej
reviewed
Jul 25, 2023
|
|
||
| .. code-block:: console | ||
|
|
||
| west build -b esp32_devkitc_wrover tests/boards/espressif_esp32/cache_coex | ||
| west flash --esp-device /dev/ttyUSB0 | ||
| west build -b <board> tests/boards/espressif_esp32/cache_coex |
LucasTambor
force-pushed
the
feature/s3_spiram
branch
from
d54676b
to
c7ca100
Compare
marekmatej
approved these changes
Jul 25, 2023
mniestroj
reviewed
Jul 26, 2023
| . = ALIGN(0x10000); | ||
| . = ALIGN(4); |
There was a problem hiding this comment.
This alignment was previously wrong / just arbitrary?
There was a problem hiding this comment.
It was arbitrary, for testing purposes. Ended up forgetting to put it on the first commit. Thanks for pointing it out
Add support for external PSRAM for esp32s3. Signed-off-by: Lucas Tamborrino <[email protected]>
Test esp32s3 for cache coexistence. Update test documentation. Signed-off-by: Lucas Tamborrino <[email protected]>
Add section to allocate memory of WiFi and NET stack in SPIRAM Signed-off-by: Lucas Tamborrino <[email protected]>
LucasTambor
force-pushed
the
feature/s3_spiram
branch
from
c7ca100
to
2cd6bd6
Compare
mniestroj
approved these changes
Jul 26, 2023
sylvioalves
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for external PSRAM for esp32s3.
Test esp32s3 for cache coexistence. Update test documentation.
Add section to allocate memory of WiFi and NET stack in SPIRAM